Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

build: add feff #2184

Merged
merged 1 commit into from
May 29, 2024
Merged

build: add feff #2184

merged 1 commit into from
May 29, 2024

Conversation

wjyrich
Copy link
Contributor

@wjyrich wjyrich commented May 16, 2024

ffmpeg Qt5 GUI

Log: add software name--feff
feff

ffmpeg Qt5 GUI

Log: add software name--feff
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • patches/0001-install.patch文件中,修改了data_bin.pathdata_app.path的值,需要确认这些路径更改是否与系统的文件路径布局和权限设置相符合。
  • 新增了updateqmupdateqm.commands变量,需要检查这些新引入的变量和指令是否已经在其他地方得到了适当的处理和测试。
  • 使用了$$PREFIX/bin/$$PREFIX/share/applications/等环境变量,需要确保这些变量在构建过程中被正确替换为实际的安装路径。

是否建议立即修改:

  • 是,特别是如果路径更改没有得到适当的处理,或者新增的代码没有经过充分测试,可能会导致安装失败或者运行时错误。

@kamiyadm kamiyadm merged commit 37a5e9e into martyr-deepin:master May 29, 2024
6 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, wjyrich

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants