Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

build: add QtScrobbler #2174

Merged
merged 1 commit into from
May 29, 2024
Merged

build: add QtScrobbler #2174

merged 1 commit into from
May 29, 2024

Conversation

wjyrich
Copy link
Contributor

@wjyrich wjyrich commented May 13, 2024

QTScrobbler ships both multiplatform GUI and CLI versions

Log: add software name--QtScrobbler
QtScrobbler

    QTScrobbler ships both multiplatform GUI and CLI versions

Log: add software name--QtScrobbler
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • patches/0001-install.patch中,删除和修改了关于man-compress相关的行,需要确认这些更改是否与项目的文档和用法说明一致。
  • 移除了man-compress.pathman-compress.extra的设置,如果项目中确实需要压缩帮助文档,则这些更改可能会影响安装时的文件路径。
  • libscrobble.cpp文件中,移除了对parse-mtp.h的包含和相应的parser对象的创建,需要确认是否有其他代码处理了MTP相关的功能。
  • QtScrobbler项目description中提到“ships both multiplatform GUI and CLI versions”,但当前提交的更改主要是针对CLI版本,没有明显的跨平台GUI版本变更。

是否建议立即修改:

  • 是,需要确保文档和功能的更改与项目的整体设计和需求保持一致,并且不会破坏现有的功能和用法。特别是对于平台兼容性描述和代码的实际实现是否匹配,需要进行充分的验证和测试。


#include "parse-log.h"
#include "parse-ipod.h"
-#ifdef HAVE_MTP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种改法不提倡啊,相当于去掉了它的特性

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, wjyrich

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kamiyadm kamiyadm merged commit fed5269 into martyr-deepin:master May 29, 2024
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants