Update tooling #169
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| dist | ||
| node_modules | ||
| .nvmrc | ||
| .nyc_output | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ require('reify'); | |
| var path = require('path'); | ||
| var express = require('express'); | ||
| var cors = require('cors'); | ||
| var JsonGraphqlServer = require('../dist/json-graphql-server-node').default; | ||
|
|
||
| var dataFilePath = process.argv.length > 2 ? process.argv[2] : './data.json'; | ||
| var data = require(path.join(process.cwd(), dataFilePath)); | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ | |
| </head> | ||
| <body> | ||
| <button id="button">Load posts</button> | ||
| <script src="../dist/json-graphql-server.umd.cjs"></script> | ||
| <script type="text/javascript"> | ||
| window.addEventListener('load', function() { | ||
| const data = { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,19 @@ | ||
| { | ||
| "name": "json-graphql-server", | ||
| "version": "2.4.1", | ||
| "type": "module", | ||
| "main": "./dist/json-graphql-server.cjs", | ||
| "module": "./dist/json-graphql-server.js", | ||
| "exports": { | ||
| ".": { | ||
| "import": "./dist/json-graphql-server.js", | ||
| "require": "./dist/json-graphql-server.cjs" | ||
| }, | ||
| "./node": { | ||
| "import": "./dist/json-graphql-server-node.js", | ||
| "require": "./dist/json-graphql-server-node.cjs" | ||
| } | ||
| }, | ||
| "repository": "[email protected]:marmelab/json-graphql-server.git", | ||
| "authors": [ | ||
| "François Zaninotto", | ||
|
|
@@ -30,44 +41,36 @@ | |
| ] | ||
| }, | ||
| "devDependencies": { | ||
| "@types/jest": "^29.5.12", | ||
| "babel-eslint": "^10.0.3", | ||
| "babel-jest": "^29.7.0", | ||
| "eslint": "^9.0.0", | ||
| "eslint-config-prettier": "^9.1.0", | ||
| "eslint-plugin-import": "^2.29.1", | ||
| "eslint-plugin-jest": "^28.2.0", | ||
| "eslint-plugin-prettier": "^5.1.3", | ||
| "husky": "^9.0.11", | ||
| "jest": "^29.7.0", | ||
| "lint-staged": "^15.2.2", | ||
| "prettier": "^3.2.5", | ||
| "supertest": "^6.3.4", | ||
| "vite": "^5.2.8" | ||
| }, | ||
| "dependencies": { | ||
| "@apollo/client": "^3.9.11", | ||
| "@graphql-tools/schema": "^10.0.3", | ||
| "cors": "^2.8.5", | ||
| "express": "^4.17.3", | ||
| "express-graphql": "^0.9.0", | ||
| "graphql": "^16.8.1", | ||
| "graphql-tag": "^2.12.6", | ||
| "graphql-type-json": "^0.3.2", | ||
| "inflection": "^3.0.0", | ||
| "lodash.merge": "^4.6.2", | ||
| "reify": "^0.20.12", | ||
| "xhr-mock": "^2.5.1" | ||
| }, | ||
| "bin": { | ||
| "json-graphql-server": "bin/json-graphql-server.js" | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,13 +51,11 @@ export default function (data) { | |
|
|
||
| const query = JSON.parse(body); | ||
|
|
||
| return graphql({ | ||
| schema, | ||
| source: query.query, | ||
| variableValues: query.variables | ||
| }).then( | ||
| (result) => ({ | ||
| status: 200, | ||
| headers: { 'Content-Type': 'application/json' }, | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this I don't understand. Would you ind explaining what it does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make jest accept our ESM code: https://jestjs.io/docs/ecmascript-modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that mean that, in order to use the CLI, our users will have to use the same flag? This would be a BC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, as said in the PR desc, I tested the CLI. I did it without any flag on latest Node LTS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The minimum required node version is 16.