Add support for custom id generation #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
May 13, 2024
README.md
Outdated
| import FakeRest from 'fakerest'; | ||
| import uuid from 'uuid'; | ||
|
|
||
| const restServer = new FakeRest.Server('http://my.custom.domain', () => uuid.v5()); |
There was a problem hiding this comment.
Since we're in for a breaking change, we can afford changing the signature to a params object. Same for Fakerest.Server.
slax57
reviewed
May 29, 2024
slax57
force-pushed
the
support-string-ids
branch
from
aed08b2 to
f5e2506
Compare
fzaninotto
approved these changes
May 30, 2024
slax57
requested changes
May 31, 2024
There was a problem hiding this comment.
Thanks for the review @fzaninotto
However I noticed a bug with some operations (such as DELETE) with the MSW implementation, which I'll need to fix before the release.
Hence this PR is still WIP.
fzaninotto
requested changes
Jun 3, 2024
| @@ -205,7 +224,7 @@ export class BaseServer { | |||
|
|
|||
| // handle collections | |||
| const matches = request.url?.match( | |||
| new RegExp(`^${this.baseUrl}\\/([^\\/?]+)(\\/(\\d+))?(\\?.*)?$`), | |||
| new RegExp(`^${this.baseUrl}\\/([^\\/?]+)(\\/(\\w))?(\\?.*)?$`), | |||
There was a problem hiding this comment.
I'm afraid this may break things
There was a problem hiding this comment.
I haven't noticed any and I don't see any other way to support custom ids
Co-authored-by: Francois Zaninotto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #68