Fix: Singular Matrix error in 3D points #8

akchan · 2024-06-23T03:05:24Z

This pull request applies changes proposed by OnDraganov in the issue #6.

Singular Matrix error raises in numpy.linalg.solve() function in case of coplanar points.

Change the judge condition in the circle_contains(). OnDraganov proposed this solution in issue #6 .

Four test cases were also added to test_miniball.py.

I have confirmed the test run by the command below successfully.

# python-3.11.8
# pytest-8.1.1
# pluggy-1.4.0
pytest test_miniball.py

Apply changes proposed by OnDraganov.

…rror of numpy.linalg.solve()

akchan added 2 commits June 23, 2024 11:25

Update miniball.py

2848fd8

Apply changes proposed by OnDraganov.

Add test_bounding_ball_3D_coplanar_cases() to check Singular Matrix e…

de1b552

…rror of numpy.linalg.solve()

Provide feedback