Add failedDecodes to LossyArray #56
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm definitely into this idea. But you also have me scratching my chin at |
|
Any reason why this PR was abandoned? Super useful to have, I need it 🤣 ! |
|
@donileo sorry man, open source is hard 😓 . I want to do more with this project, but it's hard to muster the strength at times. I would be open to the idea of having a collaborator on this repo when life gets busy, for the right person of course. 🙏 thanks for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning of an approach I'm considering regarding #41 to track failures. Rather than injecting logging into the system, it tracks failures such that you can check at the end if anything went wrong. I'm exploring whether I can use Mirror to scan a final data structure and collect all failures including in children. But I first wanted to pitch the basic approach and get any input.
I at least want to add this to the other Lossy types, and am considering how to best handle the Default types. Currently "default" is used both to mean "value when there is no value to avoid Optionals" and also "value when the data is corrupt to avoid throwing." IMO these are very different use cases, and I'm thinking through how to best split them up and make their differences explicit.