Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feng multiplerows #81

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

xfsnowind
Copy link

Add functionality of fixed columns with multiple rows, check out the examples in the demo/test.html
Use jslint to format the codes
Minify the jquery.fixedheadertable.js

Feng Xue added 2 commits July 12, 2013 15:12
…examples in the test.html

Also changed a little to defaultTheme.css
Use jslint to format the codes
@xfsnowind
Copy link
Author

This also fixes the issue #77 #79 #76

@markmalek
Copy link
Owner

Thanks for the pull-request! I'll take a look at this over the weekend.

@maartenhunink
Copy link

Thanks for this @xfsnowind, it fixed my problems.

@xfsnowind
Copy link
Author

@markmalek Hi, how is it going? Is it OK or some problems?

@marianopeck
Copy link

Hi. I am having this very same problem and the fork of xfsnowind seems to work for me. Is there any chance we get this merged and integrated here? Thanks!

@marianopeck
Copy link

grrr but that fork breaks fixedColumns since they got an incorrect width regarding the header...

@xfsnowind
Copy link
Author

Sorry, can you specify it? what do you mean?

@marianopeck
Copy link

Hi xfsnowind . I tried with your fork. First, let's see WITHOUT fixed columns.

With the main branch (this repo) I have a problem with colspan, I use this to mark that the table is empty. Look at this broken example:
screen shot 2013-10-07 at 2 59 57 pm

With your fork, I get the correct view, see image:
screen shot 2013-10-07 at 3 02 02 pm

So the problem seems to be that I am using colspan for the only row saying the table is empty.
But...now if I set fixedColumns, the first column of the body gets really big with your clone. See picture:
screen shot 2013-10-07 at 3 02 34 pm
And this happens when I define TWO fixed columns:
screen shot 2013-10-07 at 3 02 25 pm

And this is what I should really get and what I indeed get with the main clone (not yours):
screen shot 2013-10-07 at 11 45 51 am

Thoughts? have you tried your clone with fixed colums? I guess you did so I am not sure which could be the problem :(

Thanks in advance

@marianopeck
Copy link

xfsnowind : I forgot to mention something. Not only the "fixed columns" look really big (width) (that is when I don't have horizontal scroll, hence fixed columns are not really needed). But when I do have fixed columns and the need of an horizontal scrollbar, then the fixed columns do not work at all with your branch. They simply do not stick (remain visible). If there is anything I could test or help please let me know.

@xfsnowind
Copy link
Author

Yes, thanks for your information. I will look into it these days. And I also add some examples in the demo/test.html. You can check it to see if there is some useful information. If you have more situations, feel free to let me know.

@marianopeck
Copy link

Hi xfsnowind . Yes, I tried the examples in test.html from your clone and they work fine :( So I don't know what happens in my application. From what I can tell, I am not doing anything strange.

@xfsnowind
Copy link
Author

OK. But do you mind you send me your table html codes or related codes? I guess it would be better. you can send to this email: [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants