Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate project setup to pixi #10

Merged
merged 11 commits into from
Oct 4, 2024
Merged

Migrate project setup to pixi #10

merged 11 commits into from
Oct 4, 2024

Conversation

pavelzw
Copy link
Collaborator

@pavelzw pavelzw commented Oct 4, 2024

Closes #3

Copy link
Collaborator Author

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mscolnick please tell me what you think

with:
repository-url: https://test.pypi.org/legacy/
- name: Publish package on PyPi
uses: pypa/gh-action-pypi-publish@f7600683efdcb7656dec5b29656edb7bc586e597 # v1.10.3
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mscolnick you need to add OIDC trusted publishers in the pypi package for this package to be able to upload tokenless.

https://pypi.org/manage/project/mkdocs-marimo/settings/publishing/

Owner: marimo-team
Repository name: mkdocs-marimo
Workflow name: build.yml
Environment name: pypi

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you will do!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

permissions:
id-token: write
contents: write
environment: pypi
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mscolnick you need to create a github environment for this: https://github.com/marimo-team/mkdocs-marimo/settings/environments/new

feel free to add proper protection rules there

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be gated until i make this repo public, but will do once we make it public.

Comment on lines +27 to +28
# TODO: fix windows
# - windows-latest
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows builds are failing and also for some reason not finishing(?)

let's investigate this in a follow-up PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, we can push this off

@pavelzw pavelzw requested a review from mscolnick October 4, 2024 07:52
@pavelzw pavelzw mentioned this pull request Oct 4, 2024
Copy link
Contributor

@mscolnick mscolnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, feel free to merge whenever. ill handle the tasks you tagged me in

@pavelzw pavelzw merged commit 7cef87e into main Oct 4, 2024
12 checks passed
@pavelzw pavelzw deleted the pixi branch October 4, 2024 13:34
@pavelzw pavelzw mentioned this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modernize build setup
2 participants