-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate project setup to pixi #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mscolnick please tell me what you think
with: | ||
repository-url: https://test.pypi.org/legacy/ | ||
- name: Publish package on PyPi | ||
uses: pypa/gh-action-pypi-publish@f7600683efdcb7656dec5b29656edb7bc586e597 # v1.10.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mscolnick you need to add OIDC trusted publishers in the pypi package for this package to be able to upload tokenless.
https://pypi.org/manage/project/mkdocs-marimo/settings/publishing/
Owner: marimo-team
Repository name: mkdocs-marimo
Workflow name: build.yml
Environment name: pypi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you will do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
permissions: | ||
id-token: write | ||
contents: write | ||
environment: pypi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mscolnick you need to create a github environment for this: https://github.com/marimo-team/mkdocs-marimo/settings/environments/new
feel free to add proper protection rules there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might be gated until i make this repo public, but will do once we make it public.
# TODO: fix windows | ||
# - windows-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
windows builds are failing and also for some reason not finishing(?)
let's investigate this in a follow-up PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, we can push this off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, feel free to merge whenever. ill handle the tasks you tagged me in
Closes #3