-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add searchable dropdown functionality #3723
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add searchable parameter to mo.ui.dropdown that defaults to False - Create SearchableSelect component for searchable dropdown functionality - Update DropdownPlugin to use SearchableSelect when searchable=True - Add tests for searchable dropdown functionality Co-Authored-By: Myles Scolnick <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
for more information, see https://pre-commit.ci
- Update SearchableSelect to use string value type - Update DropdownPlugin to handle string/array conversion - Add tests for single string value handling - Add type declarations for test assertions Co-Authored-By: Myles Scolnick <[email protected]>
Co-Authored-By: Myles Scolnick <[email protected]>
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.11.2-dev1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3719
Add searchable functionality to mo.ui.dropdown by implementing a new SearchableSelect component, similar to the existing Multiselect component.
Changes:
searchable
boolean parameter to mo.ui.dropdown that defaults to FalseLink to Devin run: https://app.devin.ai/sessions/dd320d3ed4e44aaca33a156e885da89f
Requested by: Myles