Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: differentiate methods and properties in dark theme #3673

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Feb 3, 2025

Fixes #3670 - Methods and properties now have distinct colors from variables in dark mode, matching light mode behavior.

Changes:

  • Created custom dark theme to improve code readability
  • Methods use #61afef (blue)
  • Properties use #e5c07b (yellow)
  • Variables use #abb2bf (light gray)

Link to Devin run: https://app.devin.ai/sessions/6acf596688c143fb90ef4abb860269d2
Requested by: Myles

image

- Created custom dark theme to improve code readability
- Methods and properties now have distinct colors from variables
- Methods use #61afef (blue)
- Properties use #e5c07b (yellow)
- Variables use #abb2bf (light gray)

Fixes #3670

Co-Authored-By: Myles Scolnick <[email protected]>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 3:28pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 3:28pm

@mscolnick mscolnick merged commit f8e1686 into main Feb 3, 2025
23 checks passed
@mscolnick mscolnick deleted the devin/1738593593-fix-dark-theme-colors branch February 3, 2025 15:36
Copy link

github-actions bot commented Feb 3, 2025

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.20-dev20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Methods have the same color as variables in dark mode
1 participant