Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PhysicsCoin example: remove collision callback after handling callback #270

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update PhysicsCoin example: remove collision callback after handling callback #270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ff7940
Update PhysicsCoin to remove collision callback after handling callback
pankajvaghela Sep 22, 2024
f578d8f
Remove unused shared value in PhysicsCoin.tsx
pankajvaghela Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions package/example/Shared/src/PhysicsCoin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ import {
FilamentScene,
DefaultLight,
Camera,
CollisionCallback,
} from 'react-native-filament'
import { useCoin } from './useCoin'
import { useSharedValue } from 'react-native-worklets-core'

function PhysicsCoinRenderer() {
const world = useWorld(0, -9, 0)
Expand All @@ -33,24 +33,18 @@ function PhysicsCoinRenderer() {
id: 'floor',
})

const hasNotifiedTouchedFloor = useSharedValue(false)
const [coinABody, coinAEntity] = useCoin(
world,
[0, 3, 0.0],
useWorkletCallback((_thisBody, collidedWith) => {
useWorkletCallback<CollisionCallback>((coinRigidBody, collidedWith) => {
'worklet'

if (hasNotifiedTouchedFloor.value) {
// TODO: This keeps getting called. Maybe we want to add a unsubscribe mechanism?
return
}

if (collidedWith.id !== 'floor') {
return
}

hasNotifiedTouchedFloor.value = true
console.log('Coin touched the floor!')
coinRigidBody.setCollisionCallback(undefined);
})
)
const [coinBBody, coinBEntity] = useCoin(world, [0, 3, 0.5])
Expand Down