-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more api requests #632
Conversation
4199d9b
to
bee7233
Compare
1a4bb74
to
bc8bbdd
Compare
6e04590
to
8caeb8a
Compare
8caeb8a
to
2c5756a
Compare
@ryshoooo @marcospereirampj сan you check my MR, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @w1ndblow
Thanks a lot for the MR! :) Overall looks great, I'm super happy about these methods! I have been missing them for a while, just never got to actually implementing them. So very much appreciated!
Only added a couple of small comments
281d3e0
to
6c27ea0
Compare
6c27ea0
to
7f29ac8
Compare
Hi @ryshoooo , thank your am glad to change code for more optimal way. I use this methods for iac in ansible module, till this methods in not main branch i add use inheritance to add then in my module. I'm looking forward to delete my additiaonal methods from my module and i'll can use native functions |
Thanks @w1ndblow. Looking good, but I'm still not sure whether these methods work as expected. Can you also a couple of tests for these? |
Hi, @ryshoooo, I wrote couple of test for my functional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @w1ndblow ! LGTM
update flow, create excution config, and change priority