Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more api requests #632

Merged
merged 9 commits into from
Feb 2, 2025
Merged

Conversation

w1ndblow
Copy link
Contributor

update flow, create excution config, and change priority

@w1ndblow w1ndblow force-pushed the add_more_requests branch 3 times, most recently from 1a4bb74 to bc8bbdd Compare January 21, 2025 19:25
@w1ndblow w1ndblow force-pushed the add_more_requests branch 8 times, most recently from 6e04590 to 8caeb8a Compare January 27, 2025 09:47
@w1ndblow
Copy link
Contributor Author

@ryshoooo @marcospereirampj сan you check my MR, please?

Copy link
Collaborator

@ryshoooo ryshoooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @w1ndblow

Thanks a lot for the MR! :) Overall looks great, I'm super happy about these methods! I have been missing them for a while, just never got to actually implementing them. So very much appreciated!

Only added a couple of small comments

CHANGELOG.md Outdated Show resolved Hide resolved
src/keycloak/keycloak_admin.py Outdated Show resolved Hide resolved
src/keycloak/keycloak_admin.py Outdated Show resolved Hide resolved
src/keycloak/keycloak_admin.py Outdated Show resolved Hide resolved
src/keycloak/keycloak_admin.py Outdated Show resolved Hide resolved
src/keycloak/keycloak_admin.py Outdated Show resolved Hide resolved
src/keycloak/keycloak_admin.py Show resolved Hide resolved
@w1ndblow w1ndblow force-pushed the add_more_requests branch 3 times, most recently from 281d3e0 to 6c27ea0 Compare January 27, 2025 22:25
@w1ndblow
Copy link
Contributor Author

Hi @w1ndblow

Thanks a lot for the MR! :) Overall looks great, I'm super happy about these methods! I have been missing them for a while, just never got to actually implementing them. So very much appreciated!

Only added a couple of small comments

Hi @ryshoooo , thank your am glad to change code for more optimal way. I use this methods for iac in ansible module, till this methods in not main branch i add use inheritance to add then in my module. I'm looking forward to delete my additiaonal methods from my module and i'll can use native functions

@w1ndblow w1ndblow requested a review from ryshoooo January 27, 2025 22:41
@ryshoooo
Copy link
Collaborator

Hi @w1ndblow
Thanks a lot for the MR! :) Overall looks great, I'm super happy about these methods! I have been missing them for a while, just never got to actually implementing them. So very much appreciated!
Only added a couple of small comments

Hi @ryshoooo , thank your am glad to change code for more optimal way. I use this methods for iac in ansible module, till this methods in not main branch i add use inheritance to add then in my module. I'm looking forward to delete my additiaonal methods from my module and i'll can use native functions

Thanks @w1ndblow. Looking good, but I'm still not sure whether these methods work as expected. Can you also a couple of tests for these?

@w1ndblow
Copy link
Contributor Author

Hi, @ryshoooo, I wrote couple of test for my functional

Copy link
Collaborator

@ryshoooo ryshoooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @w1ndblow ! LGTM

@ryshoooo ryshoooo merged commit 3868652 into marcospereirampj:master Feb 2, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants