Skip to content

Commit

Permalink
Digital Credential: DigitalCredentialsRequest's request member is now…
Browse files Browse the repository at this point in the history
… called data

https://bugs.webkit.org/show_bug.cgi?id=279933
rdar://136714291

Reviewed by NOBODY (OOPS!).

The `request` member of IdentityRequestProvider is now called data.

Spec change:
WICG/digital-credentials#165

* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/dc-types.ts:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/support/helper.js:
(makeIdentityRequestProvider):
* Source/WebCore/Modules/identity/IdentityRequestProvider.idl:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
  • Loading branch information
marcoscaceres committed Jan 8, 2025
1 parent c21bff7 commit 19a4082
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export type CredentialMediationRequirement =
*/
export interface IdentityRequestProvider {
protocol: string;
request: object;
data: object;
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@ export function makeGetOptions(providersToUse = ["default"], mediation = "requir
/**
*
* @param {string} protocol
* @param {object} request
* @param {object} data
* @returns {IdentityRequestProvider}
*/
function makeIdentityRequestProvider(protocol = "protocol", request = {}) {
function makeIdentityRequestProvider(protocol = "protocol", data = {}) {
return {
protocol,
request,
data,
};
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@

dictionary IdentityRequestProvider {
required IdentityCredentialProtocol protocol;
required OpenID4VPRequest request;
required OpenID4VPRequest data;
};
Original file line number Diff line number Diff line change
Expand Up @@ -6380,7 +6380,7 @@ struct WebCore::OpenID4VPRequest {

[Nested] struct WebCore::IdentityRequestProvider {
WebCore::IdentityCredentialProtocol protocol;
WebCore::OpenID4VPRequest request;
WebCore::OpenID4VPRequest data;
};

struct WebCore::DigitalCredentialRequestOptions {
Expand Down

0 comments on commit 19a4082

Please sign in to comment.