Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance caching and logging with new features #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: enhance caching and logging with new features #8

wants to merge 1 commit into from

Conversation

cjescudero
Copy link

  • Add verbose logging option with --verbose flag
  • Improve cache mechanism to store device and access information
  • Refactor token and device data caching methods
  • Update logging configuration and error handling
  • Simplify device and access ID retrieval logic

@cjescudero
feat: enhance caching and logging with new features
8df9507 
- Add verbose logging option with --verbose flag
- Improve cache mechanism to store device and access information
- Refactor token and device data caching methods
- Update logging configuration and error handling
- Simplify device and access ID retrieval logic
@marcosav
Copy link
Owner

Hi @cjescudero,

I like the logging related changes you propose, as I left that part very unattended.
On the other hand, I don't really consider that caching deviceId is a useful feature as currently it can be provided via args (reducing extra fetching).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjescudero @marcosav