Skip to content

Commit

Permalink
Bug 1830580 [wpt PR 39755] - FSA: Relax file name checks in the Bucke…
Browse files Browse the repository at this point in the history
…tFS, a=testonly

Automatic update from web-platform-tests
FSA: Relax file name checks in the BucketFS

Unlike when saving files to the local file system, the names of files in
the the Bucket File System (a.k.a. OPFS) are obfuscated before they end
up on disk - if they even end up on disk at all.

As such, we don't need to perform the same name sanitization and
obfuscation for these files as we do for files that end up on the
user-visible file system.

See whatwg/fs#93 for context

Bug: 1399536
Change-Id: I019b393b731cd20aa4c45eade4eca19b6633e9cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4492076
Reviewed-by: Daseul Lee <dsleechromium.org>
Commit-Queue: Austin Sullivan <asullychromium.org>
Cr-Commit-Position: refs/heads/main{#1206676}

--

wpt-commits: e4c1bdf27a01716a605a70e171be797f560952bf
wpt-pr: 39755

UltraBlame original commit: 364abd441d742e0bc35abe26540b3d46125d8752
  • Loading branch information
marco-c committed Oct 30, 2023
1 parent 91451b9 commit e95d5ef
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 19 deletions.
10 changes: 3 additions & 7 deletions testing/web-platform/tests/fs/resources/test-helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,9 @@ const LOCK_ACCESS = {
};


let kPathSeparators;
if (navigator.userAgent.includes('Windows NT')) {

kPathSeparators = ['/', '\\'];
} else {
kPathSeparators = ['/'];
}


let kPathSeparators = ['/', '\\'];

async function getFileSize(handle) {
const file = await handle.getFile();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,25 +50,15 @@ directory_test(async (t, root) => {
assert_array_equals(await getSortedDirectoryEntries(root), ['file-1']);
}, 'move(name) can be called multiple times');

directory_test(async (t, root) => {
const dir = await root.getDirectoryHandle('dir', {create: true});
const handle = await createFileWithContents(t, 'file-before', 'foo', dir);
await promise_rejects_js(t, TypeError, handle.move('Lorem.'));

assert_array_equals(await getSortedDirectoryEntries(root), ['dir/']);
assert_array_equals(await getSortedDirectoryEntries(dir), ['file-before']);
assert_equals(await getFileContents(handle), 'foo');
assert_equals(await getFileSize(handle), 3);
}, 'move(name) with a name with a trailing period should fail');

directory_test(async (t, root) => {
const handle = await createFileWithContents(t, 'file-before', 'foo', root);
await promise_rejects_js(t, TypeError, handle.move('test/test'));
await promise_rejects_js(t, TypeError, handle.move('test\\test'));

assert_array_equals(await getSortedDirectoryEntries(root), ['file-before']);
assert_equals(await getFileContents(handle), 'foo');
assert_equals(await getFileSize(handle), 3);
}, 'move(name) with a name with invalid characters should fail');
}, 'move(name) with a name with path separators should fail');

directory_test(async (t, root) => {
const handle = await createFileWithContents(t, 'file-before', 'abc', root);
Expand Down

0 comments on commit e95d5ef

Please sign in to comment.