Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: add missing doc.go for proper groupName inference
Most go code generators such as kube-openapi rely on gengo [1] to infer the annotated tags. When dealing with package annotations, gengo extracts them from the doc.go file [2]. The types defined in apis/metal3.io/v1alpha1 do have a package annotated with +groupName. However, the annotation is in the groupversion_info.go file instead. You can see comments that refer to this issue [3] [4] [1] https://github.com/kubernetes/gengo/ [2] https://github.com/kubernetes/gengo/blob/2b36238f13e9b8aebe4c286c2ffb2fc71f4be3c5/types/types.go#L121-L126 [3] kubernetes/code-generator#150 (comment) [4] kubernetes/code-generator#135 Signed-off-by: Marc Nuri <[email protected]>
- Loading branch information