-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump next from 14.2.5 to 14.2.12 #123
Merged
marcaufderheyde
merged 5 commits into
develop
from
dependabot/npm_and_yarn/next-14.2.12
Sep 19, 2024
Merged
Bump next from 14.2.5 to 14.2.12 #123
marcaufderheyde
merged 5 commits into
develop
from
dependabot/npm_and_yarn/next-14.2.12
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [HOTFIX] Replaces map tiler on individual club pages (#115) Problem Solution Note * HOTFIX - Darkmode map tile (#117) Co-authored-by: marcaufderheyde <[email protected]> --------- Co-authored-by: joneshector <[email protected]> Co-authored-by: marcaufderheyde <[email protected]>
Adding a Github Actions Workflow to build and test the project for merge requests to the develop branch.
Bumps [next](https://github.com/vercel/next.js) from 14.2.5 to 14.2.12. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v14.2.5...v14.2.12) --- updated-dependencies: - dependency-name: next dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
Pull requests that update a dependency file
label
Sep 18, 2024
marcaufderheyde
approved these changes
Sep 19, 2024
marcaufderheyde
added a commit
that referenced
this pull request
Sep 19, 2024
* [HOTFIX] Replaces map tiler on individual club pages (#115) Problem Solution Note * HOTFIX - Darkmode map tile (#117) Co-authored-by: marcaufderheyde <[email protected]> * [CAN-143] Implement Drawer Problem - Mobile nav switch from overlay to Drawer Solution - Created an animated drawer - drawer.jsx - Include react-transition-group - Removed overlay *just commented out* Note - Need to implment links - Blurred background - Mobile Nav Links * [CAN-143] Bugfix: Scrolling was disabled Problem - usePreventScrolling wasn't being returned on unmount due to RTG Solution - make the usePreventScrolling hook accept a conditional variable - This way, you can dynamically prevent scrolling Note - RTG ~ React-Transition-Group - Even when unmounting, be careful of unmount calls, they aren't handled by Next or React anymore! * [CAN-143] Add Links To Drawer Problem - Links have not been added Solution - Added links for mobile nav using previous mobile nav popup - Changed Color scheme to dark - can be easily changed back Note * [CAN-143] Implement Delayed Drawer Animations Problem - Background wanted to be coloured / faded - Weird when component dismounts as background slides with it Solution - Add a nested animation to the actual drawer - Add animation delays for both background and drawer Note * [CAN-143] Right slide and Active URL CSS Problem - Animation slide in at wrong side - Active page not highlighted in nav Solution - Change react-transition-group from -100% to calc(100vw - 100%) - Implement isHomepage logic copied from Navbar Links Component and add to active link Note * [CAn-143] Refactor Tests for OverlayNav Problem - Failed to push due to failing tests - This is because Overlaynav has been massively changed. Solution - Mock Drawer Component and remove close mock Note * Cheekily adding logo and favicon to MR ;) * CAN-143 - Fix language switcher position Problem - Position of language switcher felt wrong in drawer Solution - Suggested a new position for mobile/tablet Note - Just a suggestion, happy to go for something else as well! * CAN-143 - Fix desktop navigation Problem - Giving width-100 to the outer div of the language switcher Solution - Take it out, fixes desktop navigation Note - Really not sure why this broke the navigation, but fixed * CAN-143 - Fixed double click bug for logo Problem - Were only calling onClick when pathname was home pathname Solution - If onClick provided, call it for all paths Note - I may have misunderstood, but it is supposed to do nav right? Note2 - Removed outdated test which checked onClick only called as such * CAN-143 - Added one liner to readme to test CI Problem - Want to build and test for MRs to check we good Solution - Added workflow, need to trigger it now * CAN-143 - Added actual workflow Problem - Pipeline can't run if it's only on main at the moment Solution - Add Workflow here already (might have to be on develop) * CAN-143 - Fixed casing in tests to fix pipeline Problem - Some outdated casing for test module imports Solution - Fix them * HOTFIX - Going back to non-company protection * CAN-143 - Drawer Test Suite done * [CAN-143] Add Link to Popup Image Problem - Unable to get to club listing from clicking on image Solution - Wrap image in a tag with appropriate class names for css grid. Note * [CAN-143] Increment Version Number (1.0.0 -> 1.1.0) New Features: - Animated Mobile Nav Drawer - Clickable Popup Image Tag - Drawer Component Test Suite Note - N/A * HOTFIX-Content on Request * [CAN-143] Fix Language Switcher Position Problem - Language Switcher on drawer nav not positioned properly Solution - Adjust height and width of container to be in 100% - Change position from relative to absolute of parent - Switch Language Switcher to display none instead of invisible - Removes left margin noticed on Language switcher element Note * Bump next from 14.2.5 to 14.2.12 (#123) * Dark mode update (#118) * [HOTFIX] Replaces map tiler on individual club pages (#115) Problem Solution Note * HOTFIX - Darkmode map tile (#117) Co-authored-by: marcaufderheyde <[email protected]> --------- Co-authored-by: joneshector <[email protected]> Co-authored-by: marcaufderheyde <[email protected]> * Update ClubOpenStreetMap.tsx default light mode (#119) * Create develop-ci.yml (#121) Adding a Github Actions Workflow to build and test the project for merge requests to the develop branch. * Bump next from 14.2.5 to 14.2.12 Bumps [next](https://github.com/vercel/next.js) from 14.2.5 to 14.2.12. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v14.2.5...v14.2.12) --- updated-dependencies: - dependency-name: next dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Marc Auf der Heyde <[email protected]> Co-authored-by: joneshector <[email protected]> Co-authored-by: marcaufderheyde <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump micromatch from 4.0.5 to 4.0.8 (#122) * Dark mode update (#118) * [HOTFIX] Replaces map tiler on individual club pages (#115) Problem Solution Note * HOTFIX - Darkmode map tile (#117) Co-authored-by: marcaufderheyde <[email protected]> --------- Co-authored-by: joneshector <[email protected]> Co-authored-by: marcaufderheyde <[email protected]> * Update ClubOpenStreetMap.tsx default light mode (#119) * Create develop-ci.yml (#121) Adding a Github Actions Workflow to build and test the project for merge requests to the develop branch. * Bump micromatch from 4.0.5 to 4.0.8 Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.5...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Marc Auf der Heyde <[email protected]> Co-authored-by: joneshector <[email protected]> Co-authored-by: marcaufderheyde <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: joneshector <[email protected]> Co-authored-by: marcaufderheyde <[email protected]> Co-authored-by: Fabrizio <[email protected]> Co-authored-by: Fabrizio Catinella <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
marcaufderheyde
added a commit
that referenced
this pull request
Feb 4, 2025
* [HOTFIX] Replaces map tiler on individual club pages (#115) Problem Solution Note * HOTFIX - Darkmode map tile (#117) Co-authored-by: marcaufderheyde <[email protected]> * [CAN-143] Implement Drawer Problem - Mobile nav switch from overlay to Drawer Solution - Created an animated drawer - drawer.jsx - Include react-transition-group - Removed overlay *just commented out* Note - Need to implment links - Blurred background - Mobile Nav Links * [CAN-143] Bugfix: Scrolling was disabled Problem - usePreventScrolling wasn't being returned on unmount due to RTG Solution - make the usePreventScrolling hook accept a conditional variable - This way, you can dynamically prevent scrolling Note - RTG ~ React-Transition-Group - Even when unmounting, be careful of unmount calls, they aren't handled by Next or React anymore! * [CAN-143] Add Links To Drawer Problem - Links have not been added Solution - Added links for mobile nav using previous mobile nav popup - Changed Color scheme to dark - can be easily changed back Note * [CAN-143] Implement Delayed Drawer Animations Problem - Background wanted to be coloured / faded - Weird when component dismounts as background slides with it Solution - Add a nested animation to the actual drawer - Add animation delays for both background and drawer Note * [CAN-143] Right slide and Active URL CSS Problem - Animation slide in at wrong side - Active page not highlighted in nav Solution - Change react-transition-group from -100% to calc(100vw - 100%) - Implement isHomepage logic copied from Navbar Links Component and add to active link Note * [CAn-143] Refactor Tests for OverlayNav Problem - Failed to push due to failing tests - This is because Overlaynav has been massively changed. Solution - Mock Drawer Component and remove close mock Note * Cheekily adding logo and favicon to MR ;) * CAN-143 - Fix language switcher position Problem - Position of language switcher felt wrong in drawer Solution - Suggested a new position for mobile/tablet Note - Just a suggestion, happy to go for something else as well! * CAN-143 - Fix desktop navigation Problem - Giving width-100 to the outer div of the language switcher Solution - Take it out, fixes desktop navigation Note - Really not sure why this broke the navigation, but fixed * CAN-143 - Fixed double click bug for logo Problem - Were only calling onClick when pathname was home pathname Solution - If onClick provided, call it for all paths Note - I may have misunderstood, but it is supposed to do nav right? Note2 - Removed outdated test which checked onClick only called as such * CAN-143 - Added one liner to readme to test CI Problem - Want to build and test for MRs to check we good Solution - Added workflow, need to trigger it now * CAN-143 - Added actual workflow Problem - Pipeline can't run if it's only on main at the moment Solution - Add Workflow here already (might have to be on develop) * CAN-143 - Fixed casing in tests to fix pipeline Problem - Some outdated casing for test module imports Solution - Fix them * HOTFIX - Going back to non-company protection * CAN-143 - Drawer Test Suite done * [CAN-143] Add Link to Popup Image Problem - Unable to get to club listing from clicking on image Solution - Wrap image in a tag with appropriate class names for css grid. Note * [CAN-143] Increment Version Number (1.0.0 -> 1.1.0) New Features: - Animated Mobile Nav Drawer - Clickable Popup Image Tag - Drawer Component Test Suite Note - N/A * HOTFIX-Content on Request * [CAN-143] Fix Language Switcher Position Problem - Language Switcher on drawer nav not positioned properly Solution - Adjust height and width of container to be in 100% - Change position from relative to absolute of parent - Switch Language Switcher to display none instead of invisible - Removes left margin noticed on Language switcher element Note * Bump next from 14.2.5 to 14.2.12 (#123) * Dark mode update (#118) * [HOTFIX] Replaces map tiler on individual club pages (#115) Problem Solution Note * HOTFIX - Darkmode map tile (#117) Co-authored-by: marcaufderheyde <[email protected]> --------- Co-authored-by: joneshector <[email protected]> Co-authored-by: marcaufderheyde <[email protected]> * Update ClubOpenStreetMap.tsx default light mode (#119) * Create develop-ci.yml (#121) Adding a Github Actions Workflow to build and test the project for merge requests to the develop branch. * Bump next from 14.2.5 to 14.2.12 Bumps [next](https://github.com/vercel/next.js) from 14.2.5 to 14.2.12. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v14.2.5...v14.2.12) --- updated-dependencies: - dependency-name: next dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Marc Auf der Heyde <[email protected]> Co-authored-by: joneshector <[email protected]> Co-authored-by: marcaufderheyde <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump micromatch from 4.0.5 to 4.0.8 (#122) * Dark mode update (#118) * [HOTFIX] Replaces map tiler on individual club pages (#115) Problem Solution Note * HOTFIX - Darkmode map tile (#117) Co-authored-by: marcaufderheyde <[email protected]> --------- Co-authored-by: joneshector <[email protected]> Co-authored-by: marcaufderheyde <[email protected]> * Update ClubOpenStreetMap.tsx default light mode (#119) * Create develop-ci.yml (#121) Adding a Github Actions Workflow to build and test the project for merge requests to the develop branch. * Bump micromatch from 4.0.5 to 4.0.8 Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.5...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Marc Auf der Heyde <[email protected]> Co-authored-by: joneshector <[email protected]> Co-authored-by: marcaufderheyde <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Email replies (#129) * Subject - finally responding to emails Problem - some people want content removed/added Solution - take care of requests Note - no notes * Removed address * Forgot a second address --------- Co-authored-by: marcaufderheyde <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: joneshector <[email protected]> Co-authored-by: marcaufderheyde <[email protected]> Co-authored-by: Fabrizio <[email protected]> Co-authored-by: Fabrizio Catinella <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps next from 14.2.5 to 14.2.12.
Release notes
Sourced from next's releases.
... (truncated)
Commits
6d7ced4
v14.2.12367c6e6
update prefetching jsdoc & documentation (#68047)16ad368
Ensure we chunk revalidate tag requests (#70189)77910c8
(backport) fix(eslint): allow typescript-eslint v8 (#70090)0b907c7
[ppr] Don't mark RSC requests as /_next/data requests (backport of #66249) (#...bfbc92a
v14.2.11fa51ff5
fix: correct metadata url suffix (#69959) (#70042)276ddf3
fix: settingassetPrefix
to URL format breaks HMR (#70040)9954a21
Update revalidateTag to batch tags in one request (#65296)937651f
v14.2.10Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.