Skip to content

Commit

Permalink
Bring over hotfix content update for home of hemp (#76)
Browse files Browse the repository at this point in the history
* [CAN-89] Disable Scrolling on Mobile Nav
Problem
- When mobile overlay up, scrolling still enabled
Solution
- When component is mounted - disable scrolling on events
  - DOM Mouse Scrolls
  - Wheel Events (checked by searching property on div element)
  - Touch Move
  - Any Key Events
- Package as a helper hook that can be reused on other component
- Enable Scrolling when unmount the overlay
- ASIDE: Passive Event listeners prevent blocking js code when scrolling
    - We need to tell the browser (if it is supported) to not block
    our event listeners as when need to check if the user is scrolling
Note

* [CAn-60] Overlay Not Closing on Logo Click Mobile
Problem
- Overlay not closing on logo click

Solution
- Change the condition to match exact matches instead of regex matches

Note
- This will need to be changed in future to suit params

* [CAN-60] Refactor Logo To Accept OnClick
Problem
- Clicking on mobile logo doesn't close

Solution
- Enable onclick to be a prop
- Pass close overlay to logo
- Close
Note

* [CAN-60] Refactor Logo to Accept onClick
Problem
- Logo doesn't close overlay when already on homepage

Solution
- Refactor logo to accept onClick
- If on homepage and component is clicked, execute onClick

Note

* [CAN-60] Refactor click handlers readability
Problem
- onClick doesn't really describe what is happening

Solution
- Refactor hamburger button from .jsx to .tsx
- Refactor prop name on overlaynav form handleClick to closeOverlay
- Refactor prop name hamburger button from handleClick to showOverlay

Note

* CAN-80 - Generate custom description and keywords for each club (#70)

Problem: need custom meta for SEO

Solution: painstakingly generate and paste in

* Content Hotfix for home of hemp updates (#75)

---------

Co-authored-by: Fabrizio <[email protected]>
Co-authored-by: Fabrizio Catinella <[email protected]>
  • Loading branch information
3 people authored Apr 29, 2024
1 parent c5df426 commit d2d86e9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/[locale]/clubs/clubsListContent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ const clubs: Club[] = [
imageUrl: '/club11.png',
clubPageUrl: 'https://csc-homeofhemp.de/',
slug: '',
geoLocation: [52.526034, 13.398731],
geoLocation: [52.525391, 13.398906],
},
{
key: 'club12',
Expand Down
Binary file modified public/club11.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit d2d86e9

Please sign in to comment.