[generator] Process locality object on memory for interval index building #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaGrunge
reviewed
Dec 18, 2019
LaGrunge
reviewed
Dec 18, 2019
syershov
reviewed
Dec 18, 2019
cc-engineering
force-pushed
the
generator.locality-object-in-memory
branch
4 times, most recently
from
859fbe8 to
db000c6
Compare
syershov
reviewed
Dec 19, 2019
| covering::LocalitiesCovering localitiesCovering; | ||
| while (!coveringsParts.empty()) | ||
| { | ||
| auto & part = coveringsParts.back(); |
syershov
reviewed
Dec 19, 2019
indexer/locality_index_builder.hpp
Outdated
| } | ||
|
|
||
| FileReader reader(cellsToValueFile); | ||
| DDVector<CellValuePair<uint64_t>, FileReader, uint64_t> cellsToValue(reader); | ||
| bool BuildLocalityIndex(std::string const & localityIndexPath, |
There was a problem hiding this comment.
Параметер covering должен быть первым.
syershov
reviewed
Dec 19, 2019
indexer/locality_index_builder.hpp
Outdated
| } | ||
|
|
||
| FileReader reader(cellsToValueFile); | ||
| DDVector<CellValuePair<uint64_t>, FileReader, uint64_t> cellsToValue(reader); | ||
| bool BuildLocalityIndex(std::string const & localityIndexPath, |
There was a problem hiding this comment.
Возможно стоит переименовать функцию во что-то вроде BuildCoveringIndex
syershov
reviewed
Dec 19, 2019
indexer/locality_index_builder.hpp
Outdated
| covering::GetCodingDepth<BuildingSpec::kDepthLevels>(scales::GetUpperScale()); | ||
|
|
||
| auto const id = localityObject.GetStoredId(); | ||
| auto && cells = m_buildingSpec.Cover(localityObject, cellDepth); |
There was a problem hiding this comment.
Предлагаю переименовать m_buildingSpec в m_BuilderSpec
syershov
reviewed
Dec 19, 2019
indexer/locality_index_builder.hpp
Outdated
| BuildingSpec m_buildingSpec; | ||
| }; | ||
|
|
||
| struct RegionsLocalityIndexBuildingSpec |
There was a problem hiding this comment.
RegionsLocalityIndexBuildingSpec -> RegionsIndexBuildingSpec
syershov
reviewed
Dec 19, 2019
indexer/locality_index_builder.hpp
Outdated
| } | ||
| }; | ||
|
|
||
| struct GeoObjectsLocalityIndexBuidingSpec |
There was a problem hiding this comment.
GeoObjectsLocalityIndexBuidingSpec -> GeoObjectsIndexBuidingSpec
cc-engineering
force-pushed
the
generator.locality-object-in-memory
branch
from
db000c6 to
1fd232e
Compare
syershov
reviewed
Dec 19, 2019
| } | ||
| }; | ||
|
|
||
| using RegionsLocalityIndexBuilder = LocalityIndexBuilder<RegionsIndexBuilderSpec>; |
There was a problem hiding this comment.
RegionsLocalityIndexBuilder > RegionsIndexBuilder
There was a problem hiding this comment.
сделаю отд. pr
syershov
reviewed
Dec 19, 2019
| }; | ||
|
|
||
| using RegionsLocalityIndexBuilder = LocalityIndexBuilder<RegionsIndexBuilderSpec>; | ||
| using GeoObjectsLocalityIndexBuilder = LocalityIndexBuilder<GeoObjectsIndexBuilderSpec>; |
There was a problem hiding this comment.
GeoObjectsLocalityIndexBuilder -> GeoObjectsIndexBuilder
There was a problem hiding this comment.
сделаю отд. pr
syershov
approved these changes
Dec 19, 2019
LaGrunge
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ускорение построения обратных индексов для regions и geo_objects. Обработка геометрии объектов происходит в памяти, а не через промежуточный файл. В пиках, для geo_objects, потребление памяти достигает 140Gb.
Ускорение построения
geo_objects_index.locidxв ~12 раз (42m vs 8h)