Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix autosuggest bug #2585

Merged
merged 2 commits into from
Mar 5, 2025
Merged

fix autosuggest bug #2585

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b679e77
fix autosuggest bug
jschwarz2030 Mar 4, 2025
9104dcd
switch to includes
jschwarz2030 Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/components/AutosuggestTextBox/AutosuggestTextBox.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,13 +200,11 @@ export default class AutosuggestTextBox extends Component {
};

getSearchResults = () => {
// If we are limiting tags to just preferred we don't need to provide any search results
if (this.props.limitToPreferred) {
return [];
}

// Filter out any of our original preferredResults tags so they don't show in the list twice.
return this.props.searchResults.filter((t) => !this.props.preferredResults?.contains(t.name));
return this.props.searchResults.filter((t) => !this.props.preferredResults?.includes(t.name));
};

render() {
Expand Down
Loading