Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bundling restrictions and deletion of new bundles that weren't completed on redirect #2266

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

CollinBeczak
Copy link
Collaborator

Reliant on maproulette/maproulette-backend#1104

There was an issue where multiple users could add the same task into their bundle, and this would cause problems on submission. The first user to submit their bundle had no issue but any other user that had bundled the same task would would get a "Bundle Failed" due to that task being officially in a bundle because of that first users submission. To prevent this issue, in this commit we made it so tasks were locked on bundle, and bundles would fail to create if they try to bundle with that now locked task, or any other locked task.

This error message will be displayed whenever a user attempts to bundle a task thats been locked since starting their session(locked tasks are filtered out on table load) to help with troubleshooting.

Screenshot 2024-02-12 at 11 56 00 PM

@CollinBeczak CollinBeczak changed the title add bundling restrictions and delete new bundles that weren't completed add bundling restrictions and deletion of new bundles that weren't completed on redirect Feb 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Comparison is base (ca1f85d) 23.64% compared to head (c55dced) 23.61%.
Report is 3 commits behind head on main.

Files Patch % Lines
...c/components/HOCs/WithTaskBundle/WithTaskBundle.js 0.00% 27 Missing and 7 partials ⚠️
src/services/Task/Task.js 0.00% 8 Missing and 4 partials ⚠️
src/components/TaskPane/TaskPane.js 0.00% 3 Missing ⚠️
.../components/TaskAnalysisTable/TaskAnalysisTable.js 0.00% 0 Missing and 2 partials ⚠️
...nents/Widgets/TaskBundleWidget/TaskBundleWidget.js 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2266      +/-   ##
==========================================
- Coverage   23.64%   23.61%   -0.04%     
==========================================
  Files         648      648              
  Lines       22410    22443      +33     
  Branches     6921     6934      +13     
==========================================
+ Hits         5298     5299       +1     
- Misses      14303    14329      +26     
- Partials     2809     2815       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jschwarz2030 jschwarz2030 merged commit 97d6a4a into main Feb 14, 2024
5 checks passed
@jschwarz2030 jschwarz2030 deleted the addBundlingRestrictions branch February 14, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants