Skip to content

Commit

Permalink
Fix for T205280497 ("An automatically generated diff you reviewed, D6…
Browse files Browse the repository at this point in the history
…4670888, broke some tests")

Summary:
This diff was created by the [Meta Engineering Agent](https://fb.workplace.com/groups/1205375940786433/permalink/1205378807452813/) to automatically fix the broken tests assigned to you / your team in T205280497:
- The agent searched for and edited the files it deemed relevant for fixing the tests
- After generating the patch, the broken test(s) were rerun to verify they now pass
- Regression tests were also run to verify CI still passes

 ---

**If this diff is the correct fix for T205280497, please accept the diff**. *Note that while we set a high quality bar for the agent publishing these diffs, LLM-powered agents still make mistakes, so your critical review is much appreciated and will help us improve!*

**If changes need to be made:** Please commandeer the diff, or comment with the specific changes needed.

 ---

*P.S. If you have broader feedback, please post in the [Meta Engineering Agent - Users group](https://fb.workplace.com/groups/1205375940786433)! We would love to hear from you on improving the agent to better assist you in your daily work.*

Reviewed By: bal-a

Differential Revision: D64686668

fbshipit-source-id: b984ca2b9f2173f767d92a791f60ba14b8073b94
  • Loading branch information
Kamil Nikel authored and facebook-github-bot committed Oct 28, 2024
1 parent 537275b commit 0733669
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 19 deletions.
12 changes: 4 additions & 8 deletions annotation_gui_gcp/lib/GUI.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,10 @@
from collections import defaultdict

import flask
# pyre-fixme[21]: Could not find module `annotation_gui_gcp.lib.views.cad_view`.
from annotation_gui_gcp.lib.views.cad_view import CADView
# pyre-fixme[21]: Could not find module `annotation_gui_gcp.lib.views.cp_finder_view`.
from annotation_gui_gcp.lib.views.cp_finder_view import ControlPointFinderView
# pyre-fixme[21]: Could not find module `annotation_gui_gcp.lib.views.image_view`.
from annotation_gui_gcp.lib.views.image_view import ImageView
# pyre-fixme[21]: Could not find module `annotation_gui_gcp.lib.views.tools_view`.
from annotation_gui_gcp.lib.views.tools_view import ToolsView
from .views.cad_view import CADView
from .views.cp_finder_view import ControlPointFinderView
from .views.image_view import ImageView
from .views.tools_view import ToolsView
from opensfm import dataset


Expand Down
4 changes: 1 addition & 3 deletions annotation_gui_gcp/lib/views/cad_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
from typing import Any, Dict, Tuple

import rasterio
# pyre-fixme[21]: Could not find module `annotation_gui_gcp.lib.views.web_view`.
from annotation_gui_gcp.lib.views.web_view import WebView, distinct_colors
from ..views.web_view import WebView, distinct_colors
from flask import send_file
from PIL import ImageColor

Expand All @@ -24,7 +23,6 @@ def _load_georeference_metadata(path_cad_model) -> Dict[str, Any]:
return metadata


# pyre-fixme[11]: Annotation `WebView` is not defined as a type.
class CADView(WebView):
def __init__(
self,
Expand Down
4 changes: 1 addition & 3 deletions annotation_gui_gcp/lib/views/cp_finder_view.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
# pyre-unsafe
import typing as t

# pyre-fixme[21]: Could not find module `annotation_gui_gcp.lib.views.image_view`.
from annotation_gui_gcp.lib.views.image_view import ImageView
from .image_view import ImageView


# pyre-fixme[11]: Annotation `ImageView` is not defined as a type.
class ControlPointFinderView(ImageView):
def __init__(
self,
Expand Down
3 changes: 1 addition & 2 deletions annotation_gui_gcp/lib/views/image_view.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
# pyre-unsafe
from typing import Dict, Any

# pyre-fixme[21]: Could not find module `annotation_gui_gcp.lib.views.web_view`.
from annotation_gui_gcp.lib.views.web_view import WebView, distinct_colors
from .web_view import WebView, distinct_colors


def point_color(point_id: str) -> str:
Expand Down
4 changes: 1 addition & 3 deletions annotation_gui_gcp/lib/views/tools_view.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
# pyre-unsafe
from typing import Dict, Any

# pyre-fixme[21]: Could not find module `annotation_gui_gcp.lib.views.web_view`.
from annotation_gui_gcp.lib.views.web_view import WebView
from .web_view import WebView


# pyre-fixme[11]: Annotation `WebView` is not defined as a type.
class ToolsView(WebView):
def __init__(self, main_ui, web_app):
super().__init__(main_ui, web_app, "/tools")
Expand Down

0 comments on commit 0733669

Please sign in to comment.