Skip to content

Commit

Permalink
Remove unused-variable in mapillary/opensfm/opensfm/src/bundle/error/…
Browse files Browse the repository at this point in the history
…absolute_motion_errors.h

Summary:
LLVM-15 has a warning `-Wunused-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code or (b) qualifies the variable with `[[maybe_unused]]`.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: meyering

Differential Revision: D64279137

fbshipit-source-id: 68f17d9881c727d38065cd80d8314d28ac325f52
  • Loading branch information
r-barnes authored and facebook-github-bot committed Oct 14, 2024
1 parent 7514c21 commit 03432a8
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion opensfm/src/bundle/error/absolute_motion_errors.h
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ struct RollAngleError {
T ex[3] = {T(1), T(0), T(0)}; // A point to the right of the camera (x=1)
T ez[3] = {T(0), T(0), T(1)}; // A point in front of the camera (z=1)
T Rt_ex[3], Rt_ez[3];
T tangle_ = T(angle_);
ceres::AngleAxisRotatePoint(R.data(), ex, Rt_ex);
ceres::AngleAxisRotatePoint(R.data(), ez, Rt_ez);

Expand Down

0 comments on commit 03432a8

Please sign in to comment.