Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Drop re-export of @anywidget/vite from main package #398

Merged
merged 4 commits into from
Dec 2, 2023

Conversation

manzt
Copy link
Owner

@manzt manzt commented Dec 2, 2023

This PR let's us version the Vite plugin and anywidget separately. It is technically a breaking
change for developers using our Vite plugin and importing from anywidget/vite.

Migration

// vite.config.mjs
import { defineConfig } from "vite";
-- import anywidget from "anywidget/vite";
++ import anywidget from "@anywidget/vite";

If you are already using @anywidget/vite, there are no changes necessary.

Copy link

netlify bot commented Dec 2, 2023

Deploy Preview for anywidget canceled.

Name Link
🔨 Latest commit 30eb192
🔍 Latest deploy log https://app.netlify.com/sites/anywidget/deploys/656b8aafbc978f0008fb26d2

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13624a5) 98.40% compared to head (30eb192) 98.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files           8        8           
  Lines         440      440           
=======================================
  Hits          433      433           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manzt manzt merged commit 43afacd into main Dec 2, 2023
14 checks passed
@manzt manzt deleted the manzt/drop-vite-export branch December 2, 2023 20:01
@github-actions github-actions bot mentioned this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant