Don't treat some HTTP status error codes as not errors #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously 401, 403, 503, 504, and 999 HTTP status codes were
treated as "not an error" and therefore not reported. At the time
this made sense as there was no easy way to say "do not treat 504
codes as an error, I will assume it is transient". However, with a
recent change you can do:
```yml
raise_error_excludes:
504: ['*']
```
And treat all 504s as not an error.
This commit makes all "special HTTP status codes" an error and allows
for users to configure their `raise_error_excludes` if they want to
get the old behavior back.
I found this functionality when trying to figure out why some links
that we had that there bad weren't being reported by htmlproofer. It
turned out that the broken links were coming back with "probably good"
error codes and thus we never saw them.
Closes manuzhang#77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously 401, 403, 503, 504, and 999 HTTP status codes were treated as "not an error" and therefore not reported. At the time this made sense as there was no easy way to say "do not treat 504 codes as an error, I will assume it is transient". However, with a recent change you can do:
And treat all 504s as not an error.
This commit makes all "special HTTP status codes" an error and allows for users to configure their
raise_error_excludesif they want to get the old behavior back.I found this functionality when trying to figure out why some links that we had that there bad weren't being reported by htmlproofer. It turned out that the broken links were coming back with "probably good" error codes and thus we never saw them.
Closes #77