Use Minus() to subtract masses from total ncp #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Minus algorithm makes sure that workspaces are compatible with each other, which is important for scientists when sometimes they have to subtract one workspace from another. It also improves readability of the code.
Before overwriting the benchmarks I checked that my changes did not fail the previous system tests that were in place. Updated the inputs and the benchmarks of the system tests, because the previous inputs had workspaces that had unmatching units of Y and X.
GuiMacielPereira
added
enhancement
|
There is no workspace called |
|
|
SilkeSchomann
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
Using Minus algorithm makes sure that workspaces are compatible with each other, which is important for scientists when sometimes they have to subtract one workspace from another.
It also improves readability of the code.
To test:
Code review.
Manual testing:
Activate an environment with mantidworkbench installed:
pip install .mvesuvio config~/.mvesuvio/analysis_inputs.pyanalysis_inputs_fwd_0_total_ncp_sumanalysis_inputs_fwd_0_1.0079_ncp_sumonto open plotanalysis_inputs_fwd_0_total_ncp_except_lightest_sumonto open plot