Improve deletion of workspaces that are in the ADS #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuiMacielPereira
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Deleting a workspace in the MD Histo tab no longer crashes Mantid 👍 .
The only thing I noticed is that if I follow the same steps but click rename instead of delete, then the workspace in the ADS is not correctly renamed, but I think this can go in a different PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
Deleting a workspace within MSlice that is also in the ADS caused a crash in Mantid. The reason was that deleting the workspace in MSlice updated the ADS and, as a result, the ADS triggered a deletion request for this workspace in MSlice. This request then failed as the workspace was already deleted within MSlice. To avoid this situation, MSlice does not attempt to delete non-existing workspaces anymore. In addition, all corresponding hidden workspaces are now deleted from the ADS as well.
To test:
Follow the instructions on the original issue.
Fixes #1044.