-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/process queue batch #273
base: main
Are you sure you want to change the base?
Conversation
|
bumping into an issue here while using the ProcessQueue scripts. The maybe the version of
|
For reference, this error was because nix foundry version was out of date. Fixed with |
|
||
uint256 exitsBalance = numExits * 32 ether; | ||
// assuming rewards balance = remaing multisig balance - 10% | ||
uint256 rewardsBalance = (safe.balance - exitsBalance) * 90 / 100; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protocol treasury safe: 0xe664B134d96fdB0bf7951E0c0557B87Bac5e5277
should transfer fee in this script too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking the same thing. Only way to do it consistently is to transfer 10% of rewardsToProcess
. Then it can't double spend on leftover rewards not used in the queue processing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated:
e821ea6
Notes:
PRIVATE_KEY
in.envrc.local
to sign and send the batch tx