fix: repair volar windows version and python windows paths #1141
Conversation
core/utils.py
Outdated
| if get_os_name() == "windows": | ||
| user_emacs_dir = get_emacs_func_result("get-user-emacs-directory").replace("/", "\\") | ||
| else: | ||
| user_emacs_dir = get_emacs_func_result("get-user-emacs-directory") | ||
| user_emacs_dir = repr(get_emacs_func_result("get-user-emacs-directory")).strip("'") |
There was a problem hiding this comment.
If this patch for Windows platform, why repr on non-Windows branch?
There was a problem hiding this comment.
ok i just saw that unicode parsing only works via escape sequences.
It's better to remove this.
lsp-bridge.el
Outdated
| (if (string-match "windows" (symbol-name system-type)) | ||
| (setf (cdr (assoc '("vue") lsp-bridge-multi-lang-server-extension-list)) "volar_emmet_windows") | ||
| ) |
There was a problem hiding this comment.
setf should use in defcustom
There was a problem hiding this comment.
Can you write below how to do this right way?
I don't quite understand.
I initially wanted to do this check inside defcustom but it made the code unreadable.
langserver/volar_windows.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "volar", | |||
| "name": "volar_windows", | |||
There was a problem hiding this comment.
This name should not change.
We just need change volar_windows.json name, don't need change "name"
There was a problem hiding this comment.
This causes another bug with server not found.
Lsp server gets name volar and program searches it by volar_windows.
So we need to change the name.
multiserver/volar_emmet_windows.json
Outdated
| { | ||
| "completion": ["volar_windows", "emmet-ls"], | ||
| "completion_item_resolve": ["volar_windows", "emmet-ls"], | ||
| "diagnostics": ["volar_windows", "emmet-ls"], | ||
| "code_action": ["volar_windows", "emmet-ls"], | ||
| "execute_command": ["volar_windows", "emmet-ls"], | ||
| "find_define": "volar_windows", | ||
| "find_type_define": "volar_windows", | ||
| "find_implementation": "volar_windows", | ||
| "find_references": "volar_windows", | ||
| "peek_find_definition": "volar_windows", | ||
| "peek_find_references": "volar_windows", | ||
| "formatting": "volar_windows", | ||
| "hover": "volar_windows", | ||
| "signature_help": "volar_windows", | ||
| "prepare_rename": "volar_windows", | ||
| "rename": "volar_windows", | ||
| "document_symbol": "volar_windows", | ||
| "workspace_symbol": "volar_windows", | ||
| "semantic_tokens": "volar_windows", | ||
| "inlay_hint": "volar_windows" | ||
| } |
There was a problem hiding this comment.
volar_windows.json 's name should use "volar",
above also should change to "volar".
lsp-bridge will choose volar_windows.json when it run on Windows platform
There was a problem hiding this comment.
This causes another bug that I don't remember.
I'll write it tomorrow when i reproduce it.
There was a problem hiding this comment.
Infinite creation of connections until emacs crashes.
|
@Yuki61803 I have push fb0e319 You don't need change option lsp-bridge-multi-lang-server-extension-list, lsp-bridge will use volar_emmet_windows.json instead volar_emmet.json on Windows platform. |
Ok. I'll check this push tomorrow. |
|
As you said, everything is correct. |
|
@Yuki61803 Thank you very much, good patch! ;) |
SyntaxError: (unicode error) 'unicodeescape' codec can't decode bytes in position 2-3: truncated \UXXXXXXXX escape.
Fix tested on Windows 10.