Generate rust bindings from mlibc headers #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no92
requested review from
avdgrinten,
Geertiebear,
64,
ArsenArsen,
Dennisbonke and
ElectrodeYT
no92
force-pushed
the
rust-bindings
branch
2 times, most recently
from
731f1a2 to
f3faec9
Compare
mintsuki
requested changes
Feb 13, 2024
64
reviewed
Feb 13, 2024
scripts/rust-libc-config.yml
Outdated
There was a problem hiding this comment.
Probably too awful to do now. But ideally there would be some comments explaining why certain things are ignored.
64
reviewed
Feb 13, 2024
qookei
reviewed
Feb 13, 2024
64
reviewed
Feb 13, 2024
Closed
|
Rebased onto current master. |
Qwinci
reviewed
Feb 18, 2024
mintsuki
force-pushed
the
abi-break
branch
2 times, most recently
from
40fe204 to
80b0943
Compare
no92
force-pushed
the
rust-bindings
branch
2 times, most recently
from
53bafe4 to
fb73d6f
Compare
no92
force-pushed
the
rust-bindings
branch
2 times, most recently
from
39f95b1 to
7a4562f
Compare
Geertiebear
approved these changes
Feb 24, 2024
ArsenArsen
requested changes
Feb 24, 2024
|
Updated the script to be formatted with |
This script and the configuration file supplied are tested to generate valid rust bindings (for rust's libc crate) for unix/linux_like/* targets. This has been tested by building rust's stdlib, alacritty, exa and ripgrep. In the future, it might be a worthwhile idea to run this as a GHA check to catch accidental breakage.
Geertiebear
approved these changes
Feb 26, 2024
Dennisbonke
reviewed
Feb 26, 2024
| - "B2500000" | ||
| - "B3000000" | ||
| - "B3500000" | ||
| - "B4000000" |
There was a problem hiding this comment.
Missing a newline at the end of file. We should fix that at the next opportunity but it's not a blocker for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script to generate valid, working rust-libc bindings. It parses (installed) mlibc headers using libclang, and then outputs rust bindings. A configuration file is supplied to list stuff that needs to be ignored, either due to being broken, unnecessary or already provided in
unix/mod.rsorunix/linux_like/mod.rs.