Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

termios-stub.cpp: make sure _GNU_SOURCE is defined #958

Merged
merged 1 commit into from
Dec 11, 2023
Merged

termios-stub.cpp: make sure _GNU_SOURCE is defined #958

merged 1 commit into from
Dec 11, 2023

Conversation

moodyhunter
Copy link
Contributor

need to get CBAUD, etc.

@moodyhunter
make sure _GNU_SOURCE is defined
f32823f 
need to get CBAUD, etc.
@Geertiebear
Copy link
Member

Not entirely sure if I understand the issue that this solves, could you elaborate?

@moodyhunter
Copy link
Contributor Author

Hi, a similar one is at #878

A compiler may not define _GNU_SOURCE so we have to define it to get CBAUD defined.

no92
no92 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@no92 no92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dennisbonke
Dennisbonke approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dennisbonke Dennisbonke merged commit abd16bb into managarm:master Dec 11, 2023
25 checks passed
@moodyhunter moodyhunter deleted the patch-3 branch December 11, 2023 23:01
@moodyhunter
Copy link
Contributor Author

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dennisbonke Dennisbonke Dennisbonke approved these changes

@no92 no92 no92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moodyhunter @Geertiebear @no92 @Dennisbonke