Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options/rtdl: Implement R_IRELATIVE relocation #951

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

Qwinci
Copy link
Contributor

@Qwinci Qwinci commented Nov 19, 2023

No description provided.

Copy link
Member

@no92 no92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would either need guarding by #ifdefs or something similar as this has quirks for aarch64 and RISC-V.

@Qwinci Qwinci requested a review from no92 February 4, 2024 12:56
@Qwinci Qwinci force-pushed the reloc-irelative branch 2 times, most recently from ad602bc to 98fd180 Compare February 4, 2024 13:44
@Qwinci
Copy link
Contributor Author

Qwinci commented Feb 4, 2024

This would either need guarding by #ifdefs or something similar as this has quirks for aarch64 and RISC-V.

I converted the late relocation handling to use the Relocation type and moved R_IRELATIVE handling to there because they are supposed to be processed after all other relocations. Also added #ifdefs for x86_{x64} and aarch64 (though that implementation doesn't properly pass in the hwcaps as the first argument and always just passes a zero).

Copy link
Member

@no92 no92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dennisbonke Dennisbonke merged commit cb5ba6c into managarm:master Feb 12, 2024
30 checks passed
@Qwinci Qwinci deleted the reloc-irelative branch February 17, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants