feat: add base flag to info command #3779

SandrineP · 2025-01-28T16:59:25Z

Adds one of the missing sub-command #3535

jjerphan · 2025-01-31T07:53:12Z

libmamba/src/api/info.cpp

+                std::cout << ctx.prefix_params.root_prefix.string() << std::endl;
            }
+            else


We should be able to early return in this case, also LOG_INFO is preferred generally I think.

Suggested change

std::cout << ctx.prefix_params.root_prefix.string() << std::endl;

}

else

LOG_INFO << ctx.prefix_params.root_prefix.string() << std::endl;

return;

}

and remove the parenthesis of the blocks and unindent the code to use the previous identation.

I don't understand which parenthesis you are talking about.
If I just make this change (replacing std::cout with LOG_INFO and adding return;), the output is not printed in the terminal

My bad: I meant curly brackets, and let's use std::cout.

So I leave it as is?

Actually part of my previous comment can be addressed: can you early return on the first case so that the block from line 99 to line 193 can keep the same level of indentation?

micromamba/src/info.cpp

jjerphan · 2025-01-31T08:20:21Z

micromamba/src/info.cpp

+using namespace mamba;
+


What is this used for?

It's for Configurable, which is a mamba::Configurable.

OK, in this case I propose https://github.com/mamba-org/mamba/pull/3779/files#r1936931327.

Indeed, using namespace directive should be avoided as much as possible.

It is done in /mamba/micromamba/src/list.cpp , which is why I originally went for it in /mamba/micromamba/src/info.cpp (but it used only once here, and more in list.cpp).

OK, we can remove (broad) using namespace directives in another PR.

jjerphan · 2025-01-31T09:25:33Z

micromamba/src/info.cpp

@@ -22,6 +25,11 @@ set_info_command(CLI::App* subcom, mamba::Configuration& config)
    init_info_parser(subcom, config);
    static bool print_licenses;

+    auto& base = config.insert(
+        Configurable("base", false).group("cli").description("Display base environment path.")


How about using this if this is possible?

Suggested change

Configurable("base", false).group("cli").description("Display base environment path.")

mamba::Configurable("base", false).group("cli").description("Display base environment path.")

Co-authored-by: Klaim <[email protected]>

Signed-off-by: Julien Jerphanion <[email protected]> Co-authored-by: Johan Mabille <[email protected]> Co-authored-by: Hind Montassif <[email protected]>

…mamba-org#3792) Signed-off-by: Julien Jerphanion <[email protected]>

Signed-off-by: Julien Jerphanion <[email protected]>

…rg#3788) Signed-off-by: Julien Jerphanion <[email protected]>

libmamba/src/api/info.cpp

jjerphan · 2025-02-12T16:52:37Z

libmamba/src/api/info.cpp

+                std::cout << ctx.prefix_params.root_prefix.string() << std::endl;
            }
+            else


Actually part of my previous comment can be addressed: can you early return on the first case so that the block from line 99 to line 193 can keep the same level of indentation?

micromamba/tests/test_info.py

Hind-M · 2025-02-17T14:21:31Z

libmamba/src/api/info.cpp

    namespace detail
    {
+        struct list_options


I guess this was a bad copy/paste?

Suggested change

struct list_options

struct info_options

Btw, I just realized that this is using snake case (as in list_options) but we are rather using camel case in mamba code base (RepoqueryOptions, ContextOptions, etc). So for consistency, I would say to change to ListOptions and InfoOptions.

Hind-M · 2025-02-17T14:23:40Z

libmamba/src/api/info.cpp

        {
            assert(&ctx == &config.context());
+
+            if (options.base)


We should also handle the --json case.

Hind-M · 2025-02-17T14:25:04Z

micromamba/tests/test_info.py

+    if base_flag == "--base":
+        assert all(f"{i} :" not in infos for i in items)
+        base_environment_path = infos.strip()
+        assert os.path.exists(base_environment_path)


We can add a check for the base_environment_path being tmp_root_prefix?

Hind-M · 2025-02-17T14:25:39Z

micromamba/tests/test_info.py

@@ -78,3 +78,40 @@ def test_not_env(tmp_home, tmp_root_prefix, prefix_selection, existing_prefix):
    assert f"env location : {location}" in infos
    assert f"user config files : {tmp_home / '.mambarc'}" in infos
    assert f"base environment : {tmp_root_prefix}" in infos
+
+
+@pytest.mark.parametrize("base_flag", ["", "--base"])


Add --json case.

Hind-M · 2025-02-18T10:10:49Z

libmamba/src/api/info.cpp

+
+            if (options.base)
+            {
+                if (ctx.output_params.json)


Hmm, after looking at the original code, we shouldn't use this condition here (and no cout either).
We are using info_json_print for json case, and info_pretty_print for regular output where they internally handle the previous condition.
We should modify items depending on the base flag instead.

jjerphan · 2025-02-18T20:32:25Z

micromamba/tests/test_info.py

+    else:
+        items += ["base environment"]
+        if json_flag == "--json":
+            assert all(i in infos.keys() for i in items)


Nitpick: This tests that items is a subset of infos.keys() but I guess this is sufficient

This comment also applies elsewhere.

jjerphan · 2025-02-18T20:34:23Z

libmamba/src/api/list.cpp

@@ -20,7 +20,7 @@ namespace mamba

    namespace detail
    {
-        struct list_options
+        struct ListOptions


I agree that the current *_options structs should be PascalCase-named.

add base subcommand

670491d

SandrineP force-pushed the info_base branch from 44bc606 to 670491d Compare January 30, 2025 11:57

SandrineP added the release::enhancements For enhancements PRs or implementing features label Jan 30, 2025

SandrineP marked this pull request as ready for review January 30, 2025 16:19

jjerphan reviewed Jan 31, 2025

View reviewed changes

SandrineP mentioned this pull request Feb 4, 2025

Missing command options in micromamba #3535

Open

2 tasks

jjerphan and others added 14 commits February 6, 2025 15:00

maint: Factor handling of GetModuleFileNameW (mamba-org#3785)

3abf53c

Co-authored-by: Klaim <[email protected]>

release libmamba 2.0.6.rc2, micromamba 2.0.6.rc2, libmambapy 2.0.6.rc2

2532535

feat: add canonical flag to list command (mamba-org#3777)

fd4116d

ci: Rerun pytest tests on main in case of failures (mamba-org#3769)

109b47f

Signed-off-by: Julien Jerphanion <[email protected]> Co-authored-by: Johan Mabille <[email protected]> Co-authored-by: Hind Montassif <[email protected]>

fix: Use libmamba's installation instead of mamba's as a fallback (…

d2a444c

…mamba-org#3792) Signed-off-by: Julien Jerphanion <[email protected]>

ci: Fix typo in Windows workflows (mamba-org#3793)

dac50d8

Signed-off-by: Julien Jerphanion <[email protected]>

maint: Warn about future removal of etc/profile.d/mamba.sh (mamba-o…

f201df2

…rg#3788) Signed-off-by: Julien Jerphanion <[email protected]>

release libmamba 2.0.6.rc3, micromamba 2.0.6.rc3, libmambapy 2.0.6.rc3

4ef7677

release libmamba 2.0.6, micromamba 2.0.6, libmambapy 2.0.6

1747cd8

feat: add export flag to list command (mamba-org#3780)

bc0b7db

minor fix

f7d55c8

add base test

c3f7a42

Merge branch 'main' into info_base

ed90b5d

edit test

d473b05

SandrineP force-pushed the info_base branch from b4a2cab to d473b05 Compare February 6, 2025 15:50

jjerphan reviewed Feb 12, 2025

View reviewed changes

jjerphan added release::bug_fixes For PRs fixing bugs and removed release::enhancements For enhancements PRs or implementing features labels Feb 13, 2025

SandrineP added 2 commits February 17, 2025 11:33

address review commit

8b71bfd

Merge branch 'main' into info_base

3654eea

Hind-M reviewed Feb 17, 2025

View reviewed changes

handle --json case & address review comments

a043994

Hind-M reviewed Feb 18, 2025

View reviewed changes

SandrineP added 4 commits February 18, 2025 13:52

correct handling of --json case and outputs

4e56d59

Merge branch 'main' into info_base

5e6c092

update test

c134eb4

Merge branch 'main' into info_base

c547bc7

jjerphan approved these changes Feb 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add base flag to info command #3779

feat: add base flag to info command #3779

SandrineP commented Jan 28, 2025

jjerphan Jan 31, 2025

SandrineP Jan 31, 2025

jjerphan Jan 31, 2025

SandrineP Jan 31, 2025

jjerphan Jan 31, 2025

jjerphan Feb 12, 2025

jjerphan Jan 31, 2025

SandrineP Jan 31, 2025

jjerphan Jan 31, 2025

JohanMabille Feb 5, 2025

SandrineP Feb 5, 2025

jjerphan Feb 5, 2025

jjerphan Jan 31, 2025

jjerphan Feb 12, 2025

Hind-M Feb 17, 2025

Hind-M Feb 17, 2025

SandrineP Feb 17, 2025

Hind-M Feb 17, 2025

Hind-M Feb 17, 2025

Hind-M Feb 17, 2025

Hind-M Feb 18, 2025 •

edited

Loading

jjerphan Feb 18, 2025

jjerphan Feb 18, 2025

	Configurable("base", false).group("cli").description("Display base environment path.")
	mamba::Configurable("base", false).group("cli").description("Display base environment path.")

feat: add base flag to info command #3779

Are you sure you want to change the base?

feat: add base flag to info command #3779

Conversation

SandrineP commented Jan 28, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hind-M Feb 18, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hind-M Feb 18, 2025 •

edited

Loading