Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any value in the "period_by" column in *_allele_frequencies_advanced() #723

Open
leehart opened this issue Feb 4, 2025 · 2 comments
Labels
enhancement New feature or request question Further information is requested usability

Comments

@leehart
Copy link
Collaborator

leehart commented Feb 4, 2025

Allow any value in the "period_by" column to allow for more flexible temporal grouping, particularly useful if want a span of multiple years.

@github-actions github-actions bot added the triage label Feb 4, 2025
@leehart leehart added enhancement New feature or request question Further information is requested usability and removed triage labels Feb 4, 2025
@leehart
Copy link
Collaborator Author

leehart commented Feb 4, 2025

Re: comment/question #694

@leehart leehart changed the title Allow any value in the "period_by" column in snp_allele_frequencies_advanced() Allow any value in the "period_by" column in *_allele_frequencies_advanced() Feb 4, 2025
@alimanfoo
Copy link
Member

Hi @leehart. I think what we're looking for is an option to provide the name of a column as the value of the period_by parameter.

I.e., if period_by is one of "year", "quarter" or "month" then the behaviour is unchanged. If it is any other value, then assume it is the name of a sample metadata column, and group on that column as-is (i.e., assuming the column already contains something sensible that can be grouped on, like instances of pd.Period).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested usability
Projects
None yet
Development

No branches or pull requests

2 participants