[pull] main from linkerd:main #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…3677) * refactor(app/integration): use `Result::expect()` Signed-off-by: katelyn martin <[email protected]> * refactor(app/integration): clarify `<SyncSvc as Service<T>>::call()` this commit makes some cosmetic changes to `linkerd_app_integration::tap::SyncSvc`'s implementation of `tower::Service<T>`. documentation comments are added to clarify something that makes this service slightly interesting, and notably different from code suitable for use in production / real-world contexts. this service wraps an underlying `Client`, and provides a service implementation that deals with arbitrary `B`-typed request bodies. this provides a flexible adapter that simplifies test code. this service, however, *blocks* the calling thread (off-task) to collect the body into a cheaply-cloneable `Bytes`. this commit outlines that logic into an associated function and adds additional documentation noting this property, and the basis for this assumption. Signed-off-by: katelyn martin <[email protected]> * refactor(app/integration): loosen `SyncSvc` bounds the bounds placed upon the inbound request's `B`-typed body are overly restrictive for `<SyncSvc as Service<T>>`. this commit removes some superfluous bounds, so that only those that are currently needed by this code are now required. Signed-off-by: katelyn martin <[email protected]> --------- Signed-off-by: katelyn martin <[email protected]>
cargo-deny-action is broken: EmbarkStudios/cargo-deny-action#91 This change replaces the action with a manual invocation.
`linkerd_app_integration` defines an `Error` alias. we have a boxed error type in `linkerd_app_core::Error` that achieves the same purpose, that we can use instead. this commit replaces this type alias with a reëxport of `linkerd_app_core::Error`. Signed-off-by: katelyn martin <[email protected]>
To support cross-compilation to windows, this change adds an 'os' param to the justfile, used in the release to cross-build to x86_64-pc-windows-gnu. This will produce a binary named 'linkerd2-proxy-v2.999.9-x86_64.exe'. The proxy does not yet compile on windows, so this is a placeholder for now.
`linkerd_app_integration::running()` is a public function that is not used by any external callers. this function is used in one place, when setting up test client used for integration tests. this commit inlines this logic, and moves the associated `Running` type alias down alongside the `Run` enum. Signed-off-by: katelyn martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )