Skip to content

Commit

Permalink
CLEANUP: task: move the barrier after clearing th_ctx->current
Browse files Browse the repository at this point in the history
There's a barrier after releasing the current task in the scheduler.
However it's improperly placed, it's done after pool_free() while in
fact it must be done immediately after resetting the current pointer.
Indeed, the purpose is to make sure that nobody sees the task as valid
when it's in the process of being released. This is something that
could theoretically happen if interrupted by a signal in the inlined
code of pool_free() if the compiler decided to postpone the write to
->current. In practice since nothing fancy is done in the inlined part
of the function, there's currently no risk of reordering. But it could
happen if the underlying __pool_free() were to be inlined for example,
and in this case we could possibly observe th_ctx->current pointing
to something currently being destroyed.

With the barrier between the two, there's no risk anymore.
  • Loading branch information
wtarreau committed Feb 21, 2025
1 parent eb41d76 commit e7510d6
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/task.c
Original file line number Diff line number Diff line change
Expand Up @@ -605,8 +605,11 @@ unsigned int run_tasks_from_lists(unsigned int budgets[])
else {
done++;
th_ctx->current = NULL;
pool_free(pool_head_tasklet, t);
/* signal barrier to prevent thread dump helpers
* from dumping a task currently being freed.
*/
__ha_barrier_store();
pool_free(pool_head_tasklet, t);
continue;
}
} else {
Expand Down

0 comments on commit e7510d6

Please sign in to comment.