Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miranda and Fatuma code reviewing Sabih's code #260

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

fatima-fatima
Copy link

No description provided.

Copy link

@MirandaFrudd MirandaFrudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code is really clear and easy to follow.

@@ -0,0 +1,18 @@
class Player

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests got deleted for this class

@@ -0,0 +1,18 @@

feature 'Home Page' do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great tests, but there could be more coverage of the results page

@opponent = [:Rock, :Paper, :Scissors].sample
erb :result
end

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy to follow and understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants