Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Friday finish #259

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Friday finish #259

wants to merge 4 commits into from

Conversation

erb16
Copy link

@erb16 erb16 commented Jul 11, 2022

As far as I got on Friday

RonanHughes1
RonanHughes1 reviewed Jul 11, 2022
View reviewed changes
app.rb
# end

get '/' do
erb(:index)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot the brackets lol thanks

RonanHughes1
RonanHughes1 reviewed Jul 11, 2022
View reviewed changes
Copy link

@RonanHughes1 RonanHughes1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well formatted and easy to follow

spec/player_spec.rb
end
end
end

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very tidy and easy to follow

spec/features/choose_rock_spec.rb
click_button 'Submit'
click_button 'ROCK'
expect(page).to have_content 'rock'
end
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great capybara test format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonanHughes1 RonanHughes1 RonanHughes1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erb16 @RonanHughes1 @embayli