-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPS challenge completed #256
base: main
Are you sure you want to change the base?
Conversation
|
||
get '/play' do | ||
@name1 = $player_1.name | ||
erb :play |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Referring to play view, but erb file is play_game.erb which you'd already flagged.
@@ -0,0 +1,11 @@ | |||
<h1>Rock, Paper, Scissors</h1> | |||
<hr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible line break typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall structure looking like it's coming together nicely and following the principles of what we've covered aside of some potential tiny typos which you'd already flagged anyway!
Checkpoint added to align with user stories within challenge for Rock Paper Scissors - end of week challenge