Leigh Rose rock paper scissors version 1 #234

Leigh-Rose · 2022-03-28T09:26:42Z

No description provided.

wjmarshall

Hi Leigh, here are some thoughts I had while reading your code. Looks great!

wjmarshall · 2022-03-28T09:49:32Z

app.rb

@@ -1,8 +1,33 @@
 require 'sinatra/base'


This seems a good, slim controller—logic is extracted to the lib files

wjmarshall · 2022-03-28T09:50:31Z

lib/game.rb

@@ -0,0 +1,24 @@
+class Game


Good use of single-responsibility principle in structuring of classes—each has a clear, single purpose

wjmarshall · 2022-03-28T09:53:18Z

lib/game.rb

+  def initialize(player)
+  end
+
+  def determine_winner(player_choice)


This seems quite a long method—perhaps there is a shorter solution?

wjmarshall · 2022-03-28T09:57:02Z

app.rb

  end

+  post '/names' do
+    $player_1 = Player.new(params[:player_1_name])


Perhaps there is another solution to avoid using global variables?

wjmarshall · 2022-03-28T09:59:23Z

lib/player.rb

@@ -0,0 +1,8 @@
+class Player


Nice short, simple class!

Leigh Rose added 2 commits March 25, 2022 16:23

first update

a835102

2nd update post redirect

e941250

wjmarshall reviewed Mar 28, 2022

View reviewed changes

Provide feedback