Code

Perran submission#1628

Code

Open

capatult wants to merge 45 commits intomakersacademy:mainmakersacademy/bowling-challenge:mainfrom capatult:perran-submissioncapatult/bowling-challenge:perran-submissionCopy head branch name to clipboard

+5,244-150

Commits

Commits on Nov 2, 2023

• Configured and added eslint

  capatult

  committed
  6cb40d6

  Copy full SHA for 6cb40d6

• Added jest

  capatult

  committed
  e400d39

  Copy full SHA for e400d39

• Created scorecard.js, scorecard.test.js:

  capatult

  committed
  be09e53

  Copy full SHA for be09e53

• Autoformatted with prettier

  capatult

  committed
  0a8437c

  Copy full SHA for 0a8437c

• Created class Scorecard via TDD

  capatult

  committed
  3fc208a

  Copy full SHA for 3fc208a

• Implemented Scorecard.constructor via TDD

  capatult

  committed
  fad1df0

  Copy full SHA for fad1df0

• Implemented basic error handling behaviour of Scorecard.addRoll via TDD

  capatult

  committed
  8e87fa7

  Copy full SHA for 8e87fa7

• Implemented correct behaviour for first non-strike roll of first frame for Scorecard.addRoll via TDD

  capatult

  committed
  e040613

  Copy full SHA for e040613

• Updated .gitignore

  capatult

  committed
  0677089

  Copy full SHA for 0677089

• Refactored a complex test using jest feature test.each(cases)

  capatult

  committed
  644735e

  Copy full SHA for 644735e

• Implemented correct behaviour for a strike being scored in the first frame for Scorecard.addRoll via TDD

  capatult

  committed
  80abe04

  Copy full SHA for 80abe04

• Added index.js file to help with using node in CLI; tracked index.js in .eslintignore

  capatult

  committed
  2680ad9

  Copy full SHA for 2680ad9

• Implemented correct behaviour for 2 and then 3 being rolled in the first frame for Scorecard.addRoll via TDD

  capatult

  committed
  0c5a57d

  Copy full SHA for 0c5a57d

• Added .gameFinished: boolean property to Scorecard, modified "can be constructed" test to check this is set correctly

  capatult

  committed
  87712f1

  Copy full SHA for 87712f1

• Wrote tests for 6 and then 4 (a spare) being rolled in frame 1

  capatult

  committed
  5e9e8a1

  Copy full SHA for 5e9e8a1

• Implemented correct behaviour for 6 and then 4 (a spare) being rolled in frame 1 via TDD

  capatult

  committed
  520705e

  Copy full SHA for 520705e

• Created simulateGame function in scorecard.test.js, which returns a Scorecard object

  capatult

  committed
  cb38034

  Copy full SHA for cb38034

• Renamed simulateGame to scorecardWithRolls

  capatult

  committed
  57f624a

  Copy full SHA for 57f624a

• Refactored tests to make use of scorecardWithRolls

  capatult

  committed
  2d87d92

  Copy full SHA for 2d87d92

• Implemented correct behaviour for 1, then 2, then 3 being rolled via TDD

  capatult

  committed
  2aa8a26

  Copy full SHA for 2aa8a26

• Implemented correct behaviour for 10 (a strike), then 7 in frame 2, being rolled via TDD

  capatult

  committed
  5484c6c

  Copy full SHA for 5484c6c

• Implemented correct behaviour for 10 (a strike), then 5, then 4, then 3 being rolled via TDD

  capatult

  committed
  3d48e79

  Copy full SHA for 3d48e79

• Implemented correct behaviour for the "Perfect Game" (twelve rolls of 10) via TDD

  capatult

  committed
  296c07d

  Copy full SHA for 296c07d

• Implemented error handling for .addRoll when pinsHit would exceed ._pinsRemaining

  capatult

  committed
  05c6608

  Copy full SHA for 05c6608

• Added passing test for example game in images/example_ten_pin_scoring.png

  capatult

  committed
  867b33d

  Copy full SHA for 867b33d

• Added passing test for a "Gutter Game" (twenty rolls of 0)

  capatult

  committed
  05149eb

  Copy full SHA for 05149eb

• Extensive refactoring

  capatult

  committed
  560b5ed

  Copy full SHA for 560b5ed

• Refactored roll score calculation code a bit more

  capatult

  committed
  51bd4a9

  Copy full SHA for 51bd4a9

• Implemented Scorecard.getGameStateInfo via TDD

  capatult

  committed
  ee08e52

  Copy full SHA for ee08e52

• Created .travis.yml specifying node_js version 21

  capatult

  committed
  51ef3e4

  Copy full SHA for 51ef3e4

• Added npm@10 to .travis.yml

  capatult

  committed
  1a244f7

  Copy full SHA for 1a244f7

• Refactored Scorecard.getGameStateInfo

  capatult

  committed
  1f8f37a

  Copy full SHA for 1f8f37a

• Rerranged functions in Scorecard and added comments for organisation

  capatult

  committed
  e9aea3c

  Copy full SHA for e9aea3c

• Refactored Scorecard.addRoll

  capatult

  committed
  8c30527

  Copy full SHA for 8c30527

• Created userInterface.js, userInterface.test.js

  capatult

  committed
  a09ad73

  Copy full SHA for a09ad73

• Moved README.md to docs/makers_README.md

  capatult

  committed
  b78af33

  Copy full SHA for b78af33

• Created new README.md

  capatult

  committed
  1cf3fd6

  Copy full SHA for 1cf3fd6

• Implemented UserInterface.constructor via TDD

  capatult

  committed
  f9a5248

  Copy full SHA for f9a5248

Commits on Nov 3, 2023

• Created UserInterface.tellMeTheScore as an exploratory function

  capatult

  committed
  e96521d

  Copy full SHA for e96521d

• Updated index.js to include UserInterface

  capatult

  committed
  136a63a

  Copy full SHA for 136a63a

• Commented out buggy version of UserInterface

  capatult

  committed
  2d6bc14

  Copy full SHA for 2d6bc14

• Created mainFunction (async) in main.js

  capatult

  committed
  c12f078

  Copy full SHA for c12f078

Commits on Nov 6, 2023

• Refactored UserInterface to also require a readlineInterface argument; mocked node:readline/promises and node:process in userInterface.test.js

  capatult

  committed
  268fa64

  Copy full SHA for 268fa64

• Updated README

  capatult

  committed
  ee230ea

  Copy full SHA for ee230ea

• Updated main.js to work with refactored UserInterface

  capatult

  committed
  b4af565

  Copy full SHA for b4af565