Code

Feedback#407

Code

Open

lplclaremont wants to merge 71 commits intomakersacademy:mainmakersacademy/bowling-challenge-ruby:mainfrom lplclaremont:feedbacklplclaremont/bowling-challenge-ruby:feedbackCopy head branch name to clipboard

+6,104-60

Commits

Commits on May 21, 2023

• setup rspec

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  c187ff5

  Copy full SHA for c187ff5

• created first test for frame class

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  9dd35ce

  Copy full SHA for 9dd35ce

• passed firat test

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  510882b

  Copy full SHA for 510882b

• removed rolls method

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  2eb8f0a

  Copy full SHA for 2eb8f0a

• test written for checking spares

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  522361f

  Copy full SHA for 522361f

• passed spare test

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  d488b23

  Copy full SHA for d488b23

• method for checking strike added

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  10579be

  Copy full SHA for 10579be

• added pins down attribute

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  86b792b

  Copy full SHA for 86b792b

• added pins doown attr

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  d39e097

  Copy full SHA for d39e097

• scoring basic frame test driven

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  918b473

  Copy full SHA for 918b473

• added test for valid roll input

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  13dc0ad

  Copy full SHA for 13dc0ad

• added test for spare score

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  d055849

  Copy full SHA for d055849

• spare score only updates when new roll been added

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  56d41ce

  Copy full SHA for 56d41ce

• removed return statements

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  b494ada

  Copy full SHA for b494ada

• test driven scoring a strike

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  c203179

  Copy full SHA for c203179

• test for adding strike bonus when next frame a strike passed

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  deda096

  Copy full SHA for deda096

• strike bonus handled when next roll alo a strike

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  5ab733c

  Copy full SHA for 5ab733c

• add spare followed by strike check

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  92caf49

  Copy full SHA for 92caf49

• added test for 3 strikes in a row

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  9477358

  Copy full SHA for 9477358

• added tests for tenth frame with 3 rolls

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  880b133

  Copy full SHA for 880b133

• created the BowlingGame class

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  711eedf

  Copy full SHA for 711eedf

• added test for adding frames

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  b5d8f33

  Copy full SHA for b5d8f33

• add frames test passed

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  8067be1

  Copy full SHA for 8067be1

• calculates total score for 0 frame

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  7c7950d

  Copy full SHA for 7c7950d

• added test for gutter game

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  9bdb6f4

  Copy full SHA for 9bdb6f4

• named test context better

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  0a9e581

  Copy full SHA for 0a9e581

• passed total score test for single frame

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  7cd2a4f

  Copy full SHA for 7cd2a4f

• passed test for finding total with 2 frames

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  92bac38

  Copy full SHA for 92bac38

• added test for 10 frames

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  8902148

  Copy full SHA for 8902148

• does not update total score if added frame is a spare

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  3e58eb8

  Copy full SHA for 3e58eb8

• changed structure of total_score method

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  a05e58d

  Copy full SHA for a05e58d

• passing tests for total score with spares spares

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  c23086b

  Copy full SHA for c23086b

• passes the total with spares and refactored

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  2bdc660

  Copy full SHA for 2bdc660

• added another test for strike calculation

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  d23e091

  Copy full SHA for d23e091

• another test for strike condition

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  de62e04

  Copy full SHA for de62e04

• test added for spare on last frame

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  3de5f9a

  Copy full SHA for 3de5f9a

• refactored current score method

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  078503d

  Copy full SHA for 078503d

• test driven strike behavior when start with strike

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  e39bf6a

  Copy full SHA for e39bf6a

• updated README

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  f6eef57

  Copy full SHA for f6eef57

• added test for one strike in middle

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  5a29de9

  Copy full SHA for 5a29de9

• passed test for 5 strike game

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  129c81b

  Copy full SHA for 129c81b

• passed all strike game test

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  f0830f0

  Copy full SHA for f0830f0

• refactored

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  d043633

  Copy full SHA for d043633

• require_relative in bowling_game.rb added

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  d678eb1

  Copy full SHA for d678eb1

• added index to running total

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  1b70acf

  Copy full SHA for 1b70acf

• passes final teat

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  1fea97d

  Copy full SHA for 1fea97d

Commits on May 22, 2023

• refactored strike bonus method

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  4f54ae1

  Copy full SHA for 4f54ae1

• added helper function

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  b3f6514

  Copy full SHA for b3f6514

• using helper method in test suite to simulate games

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  594969c

  Copy full SHA for 594969c

• merged test cleanup into main

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  14bb55f

  Copy full SHA for 14bb55f

• refactoring score method

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  573907a

  Copy full SHA for 573907a

• removing frames pins_down attribute

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  4d419e3

  Copy full SHA for 4d419e3

• removing comments

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  c1ac043

  Copy full SHA for c1ac043

• removing running a game in bowling_game.rb

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  d4b2ef6

  Copy full SHA for d4b2ef6

• updating README

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  9007eb8

  Copy full SHA for 9007eb8

• refactoring add_strike_bonus

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  b1f1cfe

  Copy full SHA for b1f1cfe

• removed simulation of game in the bowling_game file

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  a739c06

  Copy full SHA for a739c06

• removing redundant or statement in total_up_to(i)

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  2c01da3

  Copy full SHA for 2c01da3

• removing initial total_up_to for emepty game

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  50e8919

  Copy full SHA for 50e8919

• refactored score_sum method

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  6b7bdc6

  Copy full SHA for 6b7bdc6

• neatening up update_score method

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  a33f892

  Copy full SHA for a33f892

• checking if score == nil in update_score method

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  4b95603

  Copy full SHA for 4b95603

• refactoring continues

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  885f14a

  Copy full SHA for 885f14a

• removed require from spec helper

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  c4df492

  Copy full SHA for c4df492

• bowling_game_spec into integration folder

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  dda4fdd

  Copy full SHA for dda4fdd

• adding comments to bowling_game

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  5255850

  Copy full SHA for 5255850

• Merge branch 'main' into refactor

  lplclaremont

  authored
  d89c4c6

  Copy full SHA for d89c4c6

• Merge pull request #1 from lplclaremont/refactor

  Show description for 4535690
  lplclaremont

  authored
  4535690

  Copy full SHA for 4535690

• removing redundant :score attr_reader in frame class

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  141798b

  Copy full SHA for 141798b

• removing branches

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  268f4b5

  Copy full SHA for 268f4b5

• added feedback branch

  

  Louis Claremont

  authored and

  Louis Claremont

  committed
  25037b2

  Copy full SHA for 25037b2