Update nock to the latest version 🚀 #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 9.0.14 of nock just got published.
The version 9.0.14 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of nock.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 14 commits.
8da9ee0Fixes for Node 8612388eMerge pull request #948 from martinkuba/mastera2f170fwww.amazon.com does not return any data35c76e3Merge pull request #929 from martinkuba/node839c7e32Merge pull request #942 from michaelnisi/browserify0c0aacaSkip browserify test because zombie fails @7.10aac5c34wrap http.get on Node 8 only5db4fa0workaround for socket hang upf984668fix recorder when calling res.end(data)f6369d0use req.setHeader()119fa65override http.getc2d605aadded Node 8 to Travis17d7c25Merge pull request #667 from ksmith97/masterbcdf886Updated debug namespace to match file.See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴