Skip to content

Commit

Permalink
OSSM-5446: fix IOR test case for 2.5 & ARM (#658)
Browse files Browse the repository at this point in the history
* fix ior test case for 2.5

* add ARM to the group

* update test log

* update test logs

* update the version

* update the condition

---------

Co-authored-by: Praneeth Bajjuri <[email protected]>
  • Loading branch information
pbajjuri20 and Praneeth Bajjuri authored Feb 7, 2024
1 parent 8c4bcbe commit cfb236c
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions pkg/tests/ossm/ior_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const (

// TestIOR tests IOR error regarding routes recreated: https://issues.redhat.com/browse/OSSM-1974. IOR will be deprecated on 2.4 and willl be removed on 3.0
func TestIOR(t *testing.T) {
test.NewTest(t).Groups(test.Full).Run(func(t test.TestHelper) {
test.NewTest(t).Groups(test.Full, test.ARM).Run(func(t test.TestHelper) {
t.Log("This test verifies the behavior of IOR.")

meshNamespace := env.GetDefaultMeshNamespace()
Expand Down Expand Up @@ -77,19 +77,15 @@ func TestIOR(t *testing.T) {

DeployControlPlane(t)

t.NewSubTest("check IOR off by default v2.5").Run(func(t test.TestHelper) {
t.NewSubTest("check IOR on by default v2.5").Run(func(t test.TestHelper) {
if env.GetSMCPVersion().LessThan(version.SMCP_2_5) {
t.Skip("Skipping until 2.5")
}
t.LogStep("Check whether the IOR has the correct default setting")
if env.GetSMCPVersion().GreaterThanOrEqual(version.SMCP_2_5) {
if getIORSetting(t, meshNamespace, meshName) != "false" {
t.Fatal("Expect to find IOR disabled by default in v2.4+, but it is currently enabled")
} else {
if getIORSetting(t, meshNamespace, meshName) != "true" {
t.Fatal("Expect to find IOR enabled by default in v2.5+, but it is currently disabled")
} else {
t.LogSuccess("Got the expected false for IOR setting")
t.LogSuccess("Got the expected true for IOR setting")
}
} else {
t.Skip("IOR is not set by default versions less than v2.3")
}
})

Expand Down

0 comments on commit cfb236c

Please sign in to comment.