Fix encryption key requirement in KeycloakClientBundle #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #20 Update the encryption key configuration to make the path optional if the key is provided. * **Configuration Validation** - Add validation in `src/DependencyInjection/Configuration.php` to ensure that at least one of `encryption_key` or `encryption_key_path` is provided. * **KeycloakClient Constructor** - Update the constructor in `src/Provider/KeycloakClient.php` to throw an exception only if both `encryption_key` and `encryption_key_path` are empty. - Modify the logic to set the encryption key using either `encryption_key` or `encryption_key_path` if they are provided. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/mainick/KeycloakClientBundle/issues/20?shareId=XXXX-XXXX-XXXX-XXXX).
mainick
added a commit
that referenced
this pull request
Nov 19, 2024
Fix encryption key requirement in KeycloakClientBundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
Update the encryption key configuration to make the path optional if the key is provided.
Configuration Validation
src/DependencyInjection/Configuration.phpto ensure that at least one ofencryption_keyorencryption_key_pathis provided.KeycloakClient Constructor
src/Provider/KeycloakClient.phpto throw an exception only if bothencryption_keyandencryption_key_pathare empty.encryption_keyorencryption_key_pathif they are provided.For more details, open the Copilot Workspace session.