Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/add mailchimp api client #99

Conversation

MaxwellGarceau
Copy link
Collaborator

@MaxwellGarceau MaxwellGarceau commented Dec 31, 2024

Description of the Change

This is part of #87. The work is separated to another branch as a proof of concept before spending more time on the idea.

  • Add a FE Mailchimp client to Cypress tests to verify Mailchimp account interactions. Ensures successful form submission and full integration testing.
  • Use .env.test for env variables
  • Add health check for tests if Mailchimp client is unable to make requests
  • Modularize Cypress commands

‼️ Environment changes needed ‼️

  • Need to generate an API key for the test Mailchimp user in the CI/CD pipeline.
  • Need to attach that API key to CYPRESS_MAILCHIMP_API_KEY as a Github secret
  • Need to attach the server prefix to CYPRESS_MAILCHIMP_API_SERVER_PREFIX as a Github secret

How to test the Change

Run the cypress E2E tests

Changelog Entry

Added - Mailchimp client to testing to verify Mailchimp account interactions

Credits

Props @MaxwellGarceau

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@MaxwellGarceau MaxwellGarceau marked this pull request as ready for review December 31, 2024 03:02
@MaxwellGarceau
Copy link
Collaborator Author

In order to keep work moving I'm merging this branch into enhancement/update-critical-flows-with-e2e-test-coverage as a squash commit. Everyone's still out for the holidays.

Any comments can be addressed on the parent pull request #87.

@MaxwellGarceau MaxwellGarceau merged commit 7bf0871 into enhancement/update-critical-flows-with-e2e-test-coverage Dec 31, 2024
@MaxwellGarceau MaxwellGarceau deleted the enhancement/add-mailchimp-api-client branch December 31, 2024 19:48
@dkotter dkotter modified the milestones: 1.6.3, 1.7.0 Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants