Bug/merge fields not marked as "Visible?" in the user's Mailchimp account will still display as includable in the WP Mailchimp settings page #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In order to avoid duplicating information, please see #105 for a description of the original bug.
non-visible-merge-fields-can-still-be-set-in-the-mailchimp-wp-admin.mov
Solution
Add another conditional check to display the include checkboxes only when the merge field is public.
Closes #105
How to test the Change
This video in the "Description of the Change" demonstrating the original bug can be used as a walkthrough. However, instead of the bug you should see the fix.
Changelog Entry
Credits
Props @MaxwellGarceau
Checklist:
I have updated the documentation accordingly.No documentation to updateI have added tests to cover my change.Small fix, no test needed