Rename Configuration.php to ApiClient.php #2

katosan · 2020-08-12T16:31:40Z

composer autoload can't find the class otherwise

mc2 · 2020-08-13T20:24:49Z

Does something need to be done to specify a stable release for Composer?

$ composer require mailchimp/marketing 
                                                                               
  [InvalidArgumentException]                                                   
  Could not find package mailchimp/marketing at any version for your minimum-  
  stability (stable). Check the package spelling or your minimum-stability

alexis78i · 2020-08-13T20:32:46Z

@mc2
I set these two lines in my composer.json

 "minimum-stability": "dev",
  "prefer-stable" : true,

like this, and it works.

{
  "minimum-stability": "dev",
  "prefer-stable" : true,
  "require": {
    "mailchimp/transactional": "*",
    "mailchimp/marketing": "dev-master",
  }
}

mj4444ru · 2020-08-13T22:54:54Z

Does something need to be done to specify a stable release for Composer?

$ composer require mailchimp/marketing:dev-master

mc2 · 2020-08-14T03:31:43Z

thanks all!
I thought I saw an email address for support with this API. If you have it, please let me know.

katosan · 2020-08-14T11:02:24Z

Does something need to be done to specify a stable release for Composer?
$ composer require mailchimp/marketing:dev-master

If you want a stable version you have to tag a commit sematically e.g. 1.0.0 Composer will then determin the latest possible version for your stability requirements. e.g. composer require mailchimp/marketing:1.1.1 will not match 1.0.0

AreSanito · 2020-09-01T22:40:18Z

Hello, I pulled your branch to try to fix my bug, but I still got trouble, I'm using CodeIgniter framework with composer autoloader.
I'm having this issue : Message: Class 'MailchimpMarketing\ApiClient' not found
What should I change ?

use MailchimpMarketing\ApiClient;

class Auth extends CI_Controller
{
	public function test()
	{

		$mailchimp = new MailchimpMarketing\ApiClient();

		$mailchimp->setConfig([
			'apiKey' => 'xxxxxxxxxxxxxxxxxxxxxx-us17',
			'server' => 'us17'
		]);

		$response = $mailchimp->ping->get();
		print_r($response);
	}
}

Thanks in advance

martinbean · 2020-09-06T14:12:54Z

Any update on this? I can’t use this package because the filename doesn’t match the class name.

It’s also disappointing there seems to be no tagging going on this repository. That would be tremendously helpful when installing this package via Composer, too.

riconeitzel · 2020-09-06T16:31:18Z

Any update on this? I can’t use this package because the filename doesn’t match the class name.

You could use https://github.com/cweagans/composer-patches in the meantime. That’s quite useful for situations like this.

Rico

martinbean · 2020-09-06T17:24:18Z

You could use https://github.com/cweagans/composer-patches in the meantime. That’s quite useful for situations like this.

I’ve just forked the package and made the one-line change myself.

I wasn’t impeded by installing the library through other methods, but just curious as to why such a trivial change has been left unmerged for nearly a month now?

philcook · 2020-09-07T14:34:19Z

There is a line in the composer.json file that should do a copy of the Configuration.php file to ApiClient.php however this doesn't appear to be working for a lot of people.
I suggest this needs to be fixed rather than just make a copy and put in the repo.

The original developer probably did it this way for a reason.

    "scripts": {
        "pre-autoload-dump": "mv ./lib/Configuration.php ./lib/ApiClient.php"
    },

riconeitzel · 2020-09-07T16:10:02Z

The original developer probably did it this way for a reason.
    "scripts": {
        "pre-autoload-dump": "mv ./lib/Configuration.php ./lib/ApiClient.php"
    },

that makes no sense at all to me 😄 but good find!

philcook · 2020-09-07T16:19:52Z

The original developer probably did it this way for a reason.
    "scripts": {
        "pre-autoload-dump": "mv ./lib/Configuration.php ./lib/ApiClient.php"
    },
that makes no sense at all to me but good find!

Yes it doesn't make sense to me either but a thought maybe that there is a central codebase for their API code that in turn churns it out to all the programming languages including PHP, Ruby etc.

I guess we will have to await for the original developer to do something here.

philcook · 2020-09-07T16:26:45Z

Just worked out as a sticky plaster fix for everyone here if you add the following to your projects composer.json file this will work.

"scripts": { "pre-autoload-dump": "cp ./vendor/mailchimp/marketing/lib/Configuration.php ./vendor/mailchimp/marketing/lib/ApiClient.php" },

This fix will also work when I commit for other developers and our automated deployment system as its reading from the composer file.

dadaxr · 2020-09-08T07:12:00Z

The original developer probably did it this way for a reason.
    "scripts": {
        "pre-autoload-dump": "mv ./lib/Configuration.php ./lib/ApiClient.php"
    },
that makes no sense at all to me but good find!
Yes it doesn't make sense to me either but a thought maybe that there is a central codebase for their API code that in turn churns it out to all the programming languages including PHP, Ruby etc.

I guess we will have to await for the original developer to do something here.

As mentioned in the composer doc :

What is a script?#

A script, in Composer's terms, can either be a PHP callback (defined as a static method) or any command-line executable command. Scripts are useful for executing a package's custom code or package-specific commands during the Composer execution process.

Note: **Only scripts defined in the root package's composer.json are executed. If a dependency of the root package specifies its own scripts, Composer does not execute those additional scripts.

IMHO, renaming the file to ApiClient.php to stick to the PSR-4 standard is the right thing to do, but if for any reason they must keep this name, composer has a special autoload option : classmap which allow file name and class name to be different.

I you want people to use your official library, please make it work ;)

martinbean · 2020-09-08T08:26:37Z

[If] you want people to use your official library, please make it work ;)

💯

miradesne · 2020-09-21T22:47:00Z

Can we get this merged if possible?:)

grasmachien · 2020-09-23T14:49:21Z

After changing the filename I was greeted with another error.

Parse error: syntax error, unexpected 'list' (T_LIST), expecting identifier (T_STRING) in /vendor/mailchimp/marketing/lib/Api/AuthorizedAppsApi.php on line 65

I'm not a full time PHP developer but it seems that "list" is a reserved word and should not be used as a function...
So, I'm giving up on this library.

riconeitzel · 2020-09-23T14:57:59Z

After changing the filename I was greeting with another error.

Parse error: syntax error, unexpected 'list' (T_LIST), expecting identifier (T_STRING) in /vendor/mailchimp/marketing/lib/Api/AuthorizedAppsApi.php on line 65

You broke something in AuthorizedAppsApi.php in Line 64 ... that’s not caused by the rename.

grasmachien · 2020-09-23T15:13:52Z

You broke something in AuthorizedAppsApi.php in Line 64 ... that’s not caused by the rename.

Really weird that it is my fault because I did not change anything besides the filename :)
Also, I'm not saying the issue is caused by changing the filename.
What is the required minimum PHP version for this lib?
I can't find it in the readme.

riconeitzel · 2020-09-23T18:31:23Z

I’d guess at least php7 - we’re using it with 7.2 and 7.4

jonwinstanley · 2020-09-24T08:09:57Z

I have tweeted the maintainer of this project and asked what is supposed to happen with this library. Currently the getting started code does not work.

martinbean · 2020-09-24T17:12:46Z

Come on. Are you telling me a company with the budget and number of engineers that Mailchimp has, can’t spend an hour fixing a library for using their product? 😩

cheong999 · 2020-09-28T04:47:27Z

After changing the filename I was greeted with another error.

Parse error: syntax error, unexpected 'list' (T_LIST), expecting identifier (T_STRING) in /vendor/mailchimp/marketing/lib/Api/AuthorizedAppsApi.php on line 65

I'm not a full time PHP developer but it seems that "list" is a reserved word and should not be used as a function...
So, I'm giving up on this library.

I am running PHP 5.6, and I am facing this error too. With this error, this is unusable. Will be great if the MailChimp could rectify it as soon as possible.

based on https://www.php.net/manual/en/reserved.keywords.php, list() is a reserved keyword

Moishe · 2020-09-29T14:54:25Z

Hey all, sorry for the delays here; the new version pushed on Friday should address this issue (I just tested it on my machine from a clean install). Let me know if you see any more problems and, again, apologies for the delays.

Moishe · 2020-09-29T14:56:04Z

One other thing: this SDKs (and the SDKs for other languages) are generated from a codegen repo here: https://github.com/mailchimp/mailchimp-client-lib-codegen

We won't accept PRs on this repo (though we will use them to inform bug fixes) because they'll be overridden by the automated codegen. If you have improvements to the SDKs, the codegen repo is the place for PRs.

Thanks again for your patience / apologies it took so long.

akutaktau · 2020-10-04T16:00:33Z

composer require mailchimp/marketing:dev-master

i'm using this to install the library.

dregad · 2020-10-15T12:39:40Z

Does something need to be done to specify a stable release for Composer?

@mc2 This problem has been fixed in the latest release (3.0.22): the version is now properly tagged in the repo, allowing Packagist/Composer to pick it up.

So running composer require mailchimp/marketing will now set composer.json as expected

    "require": {
        "mailchimp/marketing": "^3.0"
    }

and there is no need to mess with @dev suffix, requiring dev-master or relying on "minimum-stability": "dev" anymore 👍

As for this issue's original problem, it has also been fixed a couple weeks ago as mentioned by @Moishe, so I think this discussion can be closed.

martinbean · 2020-10-15T12:49:20Z

Just installed mailchimp/marketing=^3.0 in a project and it does indeed seem to be fixed 🎉

Moishe · 2020-10-15T21:15:56Z

Gonna close this, because it should be resolved now. In the future please make PRs on the mailchimp-client-codegen repo (and we'll try to respond to them more quickly)

Rename Configuration.php to ApiClient.php

1580158

composer autoload can't find the class otherwise

riconeitzel approved these changes Aug 20, 2020

View reviewed changes

Moishe closed this Oct 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename Configuration.php to ApiClient.php #2

Rename Configuration.php to ApiClient.php #2

katosan commented Aug 12, 2020

mc2 commented Aug 13, 2020 •

edited

Loading

alexis78i commented Aug 13, 2020

mj4444ru commented Aug 13, 2020

mc2 commented Aug 14, 2020

katosan commented Aug 14, 2020

AreSanito commented Sep 1, 2020

martinbean commented Sep 6, 2020

riconeitzel commented Sep 6, 2020

martinbean commented Sep 6, 2020

philcook commented Sep 7, 2020

riconeitzel commented Sep 7, 2020

philcook commented Sep 7, 2020 •

edited

Loading

philcook commented Sep 7, 2020 •

edited

Loading

dadaxr commented Sep 8, 2020

martinbean commented Sep 8, 2020

miradesne commented Sep 21, 2020

grasmachien commented Sep 23, 2020 •

edited

Loading

riconeitzel commented Sep 23, 2020

grasmachien commented Sep 23, 2020

riconeitzel commented Sep 23, 2020

jonwinstanley commented Sep 24, 2020

martinbean commented Sep 24, 2020

cheong999 commented Sep 28, 2020 •

edited

Loading

Moishe commented Sep 29, 2020

Moishe commented Sep 29, 2020

akutaktau commented Oct 4, 2020

dregad commented Oct 15, 2020

martinbean commented Oct 15, 2020

Moishe commented Oct 15, 2020

Rename Configuration.php to ApiClient.php #2

Rename Configuration.php to ApiClient.php #2

Conversation

katosan commented Aug 12, 2020

mc2 commented Aug 13, 2020 • edited Loading

alexis78i commented Aug 13, 2020

mj4444ru commented Aug 13, 2020

mc2 commented Aug 14, 2020

katosan commented Aug 14, 2020

AreSanito commented Sep 1, 2020

martinbean commented Sep 6, 2020

riconeitzel commented Sep 6, 2020

martinbean commented Sep 6, 2020

philcook commented Sep 7, 2020

riconeitzel commented Sep 7, 2020

philcook commented Sep 7, 2020 • edited Loading

philcook commented Sep 7, 2020 • edited Loading

dadaxr commented Sep 8, 2020

martinbean commented Sep 8, 2020

miradesne commented Sep 21, 2020

grasmachien commented Sep 23, 2020 • edited Loading

riconeitzel commented Sep 23, 2020

grasmachien commented Sep 23, 2020

riconeitzel commented Sep 23, 2020

jonwinstanley commented Sep 24, 2020

martinbean commented Sep 24, 2020

cheong999 commented Sep 28, 2020 • edited Loading

Moishe commented Sep 29, 2020

Moishe commented Sep 29, 2020

akutaktau commented Oct 4, 2020

dregad commented Oct 15, 2020

martinbean commented Oct 15, 2020

Moishe commented Oct 15, 2020

mc2 commented Aug 13, 2020 •

edited

Loading

philcook commented Sep 7, 2020 •

edited

Loading

philcook commented Sep 7, 2020 •

edited

Loading

grasmachien commented Sep 23, 2020 •

edited

Loading

cheong999 commented Sep 28, 2020 •

edited

Loading