Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing onPress event + adding children option other than string #159

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

groger
Copy link

@groger groger commented Aug 15, 2022

  • Fixed onPress event that wasn't working, it wasn't firing (Web). Issue is TouchableWithoutFeedback always needs to have child View component. So a component that composes a View isn't enough. So added an extra View around Animated.View
  • Added an option to pass either a string as children prop where we applied textStyle and textColor like before or any type of children

I tested those modifications in my project with patch-package and it's working great and shouldn't break anything with anyone who has that library installed

@adamlbailey
Copy link

+1 to this!!

@ClementPF
Copy link

I need this too!

@ghost
Copy link

ghost commented Aug 29, 2022

+1

@bradjones1
Copy link
Contributor

Came here looking for something like this, thank you. However, (and not speaking for the maintainer) this PR is not merge-able with the changes to the lockfile and package name, etc. If you need an installable copy of your changes, I suggest making a branch on your fork for that purpose.

I also think that this could potentially be accomplished by changing the use of TouchableWithoutFeedback to Pressable, as the latter is deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants