-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tailwindui css layout support - colon is not accepted by the pattern #34559
Tailwindui css layout support - colon is not accepted by the pattern #34559
Conversation
Hi @in-session. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests EE, Functional Tests CE, Unit Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Failing tests are not related to changes from this PR |
Hi @ihor-sviziev, thank you for the review.
|
@in-session thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
@magento give me test instance |
Hi @in-session. Thank you for your request. I'm working on Magento instance for you. |
Hi @in-session, here is your Magento Instance: https://5b7bd3eb62d4df337279e14275704f53.instances.magento-community.engineering |
I created a module that should fix this in the meantime: |
Doesn't this miss some cases? https://docs.hyva.io/hyva-themes/building-your-theme/styling-layout-containers.html
|
Yes because of change from Version 2 to 3 also for page builder. We need to open a new merge for it. |
mx-[-50vw] = -mx-[50vw]? |
Not sure, that's the example from https://docs.hyva.io/hyva-themes/faqs/full-bleed-cms-content.html |
Update PR in #36452 |
Close: magento#38235 discussed in magento#32004 and magento#34430 improved in magento#36452 and magento#34559
https://tailwindcss.com/docs/responsive-design#overview
Fixes #34430